Skip to content

feat: add skill for sap fiori elements development#4832

Open
vinayhospete wants to merge 7 commits into
mainfrom
feat/fiori-mcp/skills
Open

feat: add skill for sap fiori elements development#4832
vinayhospete wants to merge 7 commits into
mainfrom
feat/fiori-mcp/skills

Conversation

@vinayhospete

@vinayhospete vinayhospete commented Jun 12, 2026

Copy link
Copy Markdown
Member

internal issue: 38027

Add SAP Fiori Elements Development Skill

New Feature

✨ Introduces a new sap-fiori skill for the @sap-ux/fiori-mcp-server package, providing AI-guided guidelines for creating and developing SAP Fiori UI applications as part of CAP or ABAP RAP projects.

Changes

  • .changeset/large-ideas-report.md: Adds a minor changeset entry for the new sap-fiori skill in the @sap-ux/fiori-mcp-server package.
  • packages/fiori-mcp-server/skills/sap-fiori/SKILL.md: Introduces a comprehensive skill definition file covering:
    • General guidelines applicable to both CAP and RAP backends (data model structure, tool usage, modification best practices)
    • Available application templates (e.g., List Report Object Page, Analytical List Page, Overview Page, Worklist, etc.)
    • Available page types (ListReport, ObjectPage, CustomPage)
    • Application structure and preview guidelines
    • CAP-specific guidelines (app folder placement, UUID keys, CSV sample data format)
    • RAP/ABAP-specific guidelines (destination/system name resolution, OData service metadata discovery, annotation file modifications, mock data generation)
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.22.8

  • Event Trigger: pull_request.opened
  • Output Template: Default Template
  • LLM: anthropic--claude-4.6-sonnet
  • Summary Prompt: Default Prompt
  • Correlation ID: 1a78bf03-6251-4697-b8c1-63a7833c398c
  • File Content Strategy: Full file content

@hyperspace-insights hyperspace-insights Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds a new SKILL.md guidance file for SAP Fiori Elements development and an accompanying changeset. The content is well-structured and comprehensive, covering both CAP and RAP/ABAP workflows.

One minor issue was flagged: trailing whitespace on line 73 of SKILL.md (after dataSources).). Additionally, the file is missing a trailing newline at the end (line 75), which violates POSIX text file conventions and can produce noisy diffs. Both are small but worth fixing before merge. The skills/ directory should also be verified to be included in the package.json files array if the skill file needs to be shipped with the published npm package.

PR Bot Information

Version: 1.22.8

  • Event Trigger: pull_request.opened
  • LLM: anthropic--claude-4.6-sonnet
  • Correlation ID: 1a78bf03-6251-4697-b8c1-63a7833c398c
  • Agent Instructions:
  • File Content Strategy: Full file content

Comment thread packages/fiori-mcp-server/skills/sap-fiori/SKILL.md Outdated
Co-authored-by: hyperspace-insights[bot] <209611008+hyperspace-insights[bot]@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6e00aa1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/fiori-mcp-server Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devinea devinea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some comments

- Inform the user that the UI has been created successfully
- Ask if they need help with anything else
- Do not double-check or verify if the UI was created successfully - trust that the Fiori MCP Server tools completed the task as intended.
4. The data model must be suitable for SAP Fiori elements: one main entity with one or more navigation properties to related entities.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one or more navigation properties to related entities.

Object page could be bound to the main entity?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had this rule before in our fiori mcp rules which describes close to below metadata structure
Screenshot 2026-06-12 at 8 42 47 PM

Comment thread packages/fiori-mcp-server/skills/sap-fiori/SKILL.md Outdated
## RAP/ABAP-Specific Guidelines

1. For standalone Fiori applications based on RAP/ABAP backend, the application is created at the root level by Fiori MCP tools.
2. **SAP System/Destination Name**: If the SAP system or destination name (e.g., UI3CLNT000) is not provided by the user:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. **SAP System/Destination Name**: If the SAP system or destination name (e.g., UI3CLNT000) is not provided by the user:
2. **SAP System/Destination Name**: If the SAP system or destination name (e.g., DEVCLNT000) is not provided by the user:

Also may need to hold off on this until @IainSAP adds the support for destinations.

@vinayhospete vinayhospete Jun 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. lets wait for destination support

Comment thread packages/fiori-mcp-server/skills/sap-fiori/SKILL.md Outdated
Comment thread packages/fiori-mcp-server/skills/sap-fiori/SKILL.md
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants