Feat(create): add skill for @sap-ux/create cli#4846
Conversation
🦋 Changeset detectedLatest commit: 1a8104f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
heimwege
changed the title
SummaryThe following content is AI-generated and provides a summary of the pull request: Add MCP Skill for
|
![hyperspace-insights[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR has two issues to address: the changeset summary prefix must be uppercased (FEAT: not feat:) to pass CI validation, and the cross-package write from generate-skill.js into fiori-mcp-server creates an implicit coupling not reflected in the dependency graph. Both have been flagged above.
| '@sap-ux/create': patch | ||
| --- | ||
|
|
||
| feat: add skill for usage of @sap-ux/create cli |
There was a problem hiding this comment.
Best Practices: The changeset summary prefix feat: is lowercase but the repo enforces uppercase prefixes (FEAT:, FIX:, BUMP:) via pnpm validate:changesets — this will fail the CI changeset validation gate.
| feat: add skill for usage of @sap-ux/create cli | |
| FEAT: add skill for usage of @sap-ux/create cli |
Double-check suggestion before committing. Edit this comment for amendments.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
| const PACKAGE_JSON_PATH = path.resolve(__dirname, '../package.json'); | ||
| const SKILL_OUTPUT_PATH = path.resolve( | ||
| __dirname, | ||
| '../../fiori-mcp-server/skills/sap-fiori-create-cli/SKILL.md' |
There was a problem hiding this comment.
Maintainability: The generate-skill.js build script for @sap-ux/create writes directly into @sap-ux/fiori-mcp-server's source tree, but there is no declared dependency between these packages. Building fiori-mcp-server independently (or running tsc --build without the full build script) will leave a stale or missing SKILL.md, with no error surfaced to the consumer.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
devinea
left a comment
devinea
left a comment
There was a problem hiding this comment.
new skill and generate script look useful
changeset ✅
|
3 participants
Add MCP Skill for
@sap-ux/createCLIIntroduces a new MCP skill (
sap-fiori-create-cli) in@sap-ux/fiori-mcp-serverthat gives AI agents a structured reference for all@sap-ux/createCLI commands. The skill is auto-generated at build time from the existingREADME.md, so it stays in sync automatically.How it works
packages/create/scripts/generate-skill.jsreadsREADME.md, strips badges/header/usage, prepends YAML frontmatter + behavioral guidance, and writesSKILL.mdtopackages/fiori-mcp-server/skills/sap-fiori-create-cli/buildscript inpackages/create/package.jsonrunsgenerate-skill.jsafter the existinggenerate-readme.jssteppackage.jsonso it always reflects the current CLI versionWorkflow sub-skill pattern
The generator supports inline workflow guides for specific commands. Drop a file at:
On the next build, a pointer is automatically injected into
SKILL.mdnext to that command:This allows self-contained workflow skills (e.g. for
convert preview-config) to live inside the CLI skill — one install, no dependencies.Changes
packages/create/scripts/generate-skill.js— new build scriptpackages/create/package.json— extendbuildscriptpackages/fiori-mcp-server/skills/sap-fiori-create-cli/SKILL.md— generated skill (do not edit manually)packages/fiori-mcp-server/skills/sap-fiori-create-cli/references/convert-preview-config.md— first workflow guide: full migration workflow forconvert preview-configincluding prerequisites, manual HTML sandbox init migration, Karma and WebdriverIO config updates.changeset/chilly-terms-sink.md— minor bump for@sap-ux/fiori-mcp-server, patch for@sap-ux/create