Skip to content

Add securityContext support to pre-delete Job#619

Open
shahar-h wants to merge 3 commits intoSAP:mainfrom
shahar-h:pre-delete-security-context
Open

Add securityContext support to pre-delete Job#619
shahar-h wants to merge 3 commits intoSAP:mainfrom
shahar-h:pre-delete-security-context

Conversation

@shahar-h
Copy link
Copy Markdown

Pull Request Template

Prerequisites

  • If there is no issue related to your pull request - open one and assign yourself to it. If you're proposing a solution to an already opened issue - simply assign yourself to it.

Motivation

The pre-delete Helm hook Job was missing securityContext configuration, making it non-compliant with restricted Pod Security Standards. Clusters enforcing these standards reject workloads without proper security context. The deployment template already supported both manager.podSecurityContext and manager.securityContext values — the pre-delete job was the only workload missing them.

Approach

Added both pod-level and container-level securityContext support to the pre-delete job template (sapbtp-operator-charts/templates/pre-delete-job.yml), reusing the existing manager.podSecurityContext and manager.securityContext values from values.yaml. This ensures consistent security posture across all chart workloads without introducing additional configuration. Used {{- with }} for cleaner templating.

Pull Request status

  • Initial implementation
  • Refactoring
  • Unit tests
  • Integration tests

Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.

Third-party code

If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.

Work in Progress label

For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].

For example: [WIP] Service brokers API

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Apr 27, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shahar-h
❌ I065450
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants