Skip to content

CXSPA-7650: Subscription Product Details Page #19330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

CXSPA-7650: Subscription Product Details Page #19330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
cf43a17
chore: adding new library
anjana-bl Sep 11, 2024
be14e5d
chore: code changes
anjana-bl Sep 24, 2024
42ccb49
Merge branch 'develop' into feature/subscription-billing
anjana-bl Sep 24, 2024
552a58b
chore: config update
anjana-bl Sep 24, 2024
250a019
Update subscription-billing.json
anjana-bl Sep 24, 2024
b99c463
Update subscription-product.module.ts
anjana-bl Oct 1, 2024
b78b96a
chore: hiding item counter
anjana-bl Oct 1, 2024
07b4332
chore: adding unit tests
anjana-bl Oct 3, 2024
de216c4
chore: model changes
anjana-bl Oct 3, 2024
b825b86
chore: E2E Test
anjana-bl Oct 3, 2024
1101427
Merge branch 'develop' into feature/subscription-billing
anjana-bl Oct 3, 2024
c2d41e9
Add license header
github-actions[bot] Oct 3, 2024
abcba5a
chore: unit test case + sonar error
anjana-bl Oct 3, 2024
5719d27
chore: fixing unit test case failure
anjana-bl Oct 4, 2024
c5eb15c
chore: lint update
anjana-bl Oct 4, 2024
85e602a
Merge branch 'develop' into feature/subscription-billing
anjana-bl Oct 4, 2024
6f77136
Merge branch 'develop' into feature/subscription-billing
anjana-bl Oct 5, 2024
56f5881
chore: update config
anjana-bl Oct 7, 2024
33d316f
chore: updating html and styling
anjana-bl Oct 7, 2024
e0a80fa
Update subscription-billing.json
anjana-bl Oct 7, 2024
46997de
Merge branch 'develop' into feature/subscription-billing
anjana-bl Oct 7, 2024
b200a77
chore: e2e update
anjana-bl Oct 7, 2024
1ba263f
Update subscription-product.module.ts
anjana-bl Oct 7, 2024
42887a3
chore: linting
anjana-bl Oct 7, 2024
c67aec4
Merge branch 'develop' into feature/subscription-billing
anjana-bl Mar 19, 2025
b20b94b
Add license header
github-actions[bot] Mar 19, 2025
6d1990f
chore: undoing irrelavant changes
anjana-bl Mar 19, 2025
3acc62d
Merge branch 'feature/subscription-billing' of https://github.com/SAP…
anjana-bl Mar 19, 2025
540c64f
Merge branch 'develop' into feature/subscription-billing
anjana-bl Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .env-cmdrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,9 @@
"CX_BASE_URL": "https://api.cg79x9wuu9-eccommerc1-s8-public.model-t.myhybris.cloud",
"CX_S4_SERVICE": "true",
"CX_B2B": "true"
},
"subscription-billing":{
"CX_BASE_URL": "https://api.cg79x9wuu9-eccommerc1-s1-public.model-t.myhybris.cloud",
"CX_SUBSCRIPTION_BILLING": "true"
}
}
9 changes: 9 additions & 0 deletions core-libs/setup/tsconfig.spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
1 change: 1 addition & 0 deletions extra-webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ module.exports = {
'@spartacus/s4om': path.join(__dirname, 'integration-libs/s4om'),
'@spartacus/opf': path.join(__dirname, 'integration-libs/opf'),
'@spartacus/s4-service': path.join(__dirname, 'integration-libs/s4-service'),
'@spartacus/subscription-billing': path.join(__dirname, 'integration-libs/subscription-billing'),
'@spartacus/omf': path.join(__dirname, 'integration-libs/omf'),
},
},
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/asm/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
24 changes: 24 additions & 0 deletions feature-libs/cart/base/components/add-to-cart/add-to-cart.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ class MockCurrentProductService {
getProduct(): Observable<Product> {
return EMPTY;
}
showItemCounter(_product: Product): boolean {
return true;
}
}

class MockProductAvailabilityAdapter {}
Expand Down Expand Up @@ -414,6 +417,27 @@ describe('AddToCartComponent', () => {
const quantityEl = el.query(By.css('.quantity'));
expect(quantityEl).toBeNull();
});
it('should not show quantity (item counter) button if explicitly set to be hidden', () => {
spyOn(currentProductService, 'getProduct').and.returnValue(
of(mockProduct)
);
spyOn(currentProductService, 'showItemCounter').and.returnValue(false);
addToCartComponent.showQuantity = true;
addToCartComponent.ngOnInit();
fixture.detectChanges();
const quantityEl = el.query(By.css('.quantity'));
expect(quantityEl).toBeNull();
});
it('should not show quantity (item counter) button if it fails condition, even if explicitly set to show', () => {
spyOn(currentProductService, 'getProduct').and.returnValue(
of(mockProduct)
);
addToCartComponent.showQuantity = false;
addToCartComponent.ngOnInit();
fixture.detectChanges();
const quantityEl = el.query(By.css('.quantity'));
expect(quantityEl).toBeNull();
});

describe('Inventory Display test', () => {
it('should display inventory quantity when enabled', () => {
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/cart/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/checkout/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/customer-ticketing/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/estimated-delivery-date/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/order/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/organization/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/pdf-invoices/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/pickup-in-store/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/product-configurator/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/product-multi-dimensional/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/product/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/qualtrics/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/quote/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/requested-delivery-date/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/smartedit/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/storefinder/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/tracking/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions feature-libs/user/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
9 changes: 9 additions & 0 deletions integration-libs/cdc/tsconfig.schematics.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,15 @@
"@spartacus/segment-refs/root": [
"../../integration-libs/segment-refs/root/public_api"
],
"@spartacus/subscription-billing/assets": [
"../../integration-libs/subscription-billing/assets/public_api"
],
"@spartacus/subscription-billing": [
"../../integration-libs/subscription-billing/public_api"
],
"@spartacus/subscription-billing/root": [
"../../integration-libs/subscription-billing/root/public_api"
],
"@spartacus/assets": ["../../projects/assets/src/public_api"],
"@spartacus/core": ["../../projects/core/public_api"],
"@spartacus/storefront": ["../../projects/storefrontlib/public_api"]
Expand Down
Loading
Loading