test: add PDP/PLP add to cart dialog e2e test #20102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9645
|
| Run status |
|
| Run duration | 05m 13s |
| Commit |
|
| Committer | Uros Lates |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
102
|
| View all changes introduced in this branch ↗︎ | |
Pio-Bar
requested changes
Apr 2, 2025
uroslates
changed the title
Pio-Bar
requested changes
Apr 7, 2025
| }); | ||
| }); | ||
|
|
||
| context('Add to Cart (PLP)', () => { |
There was a problem hiding this comment.
Is the modal triggered from a PLP any different to the one from elsewhere? If not, would one test be enough?
Comment on lines
21
to
23
| cy.get('cx-added-to-cart-dialog') | ||
| .get('.cx-modal-content') | ||
| .a11yRunContinuumTest(); |
There was a problem hiding this comment.
We need to get some content from the modal to make sure Cypress waits long enough. Currently the test runs on a mostly empty dialog.
Pio-Bar
previously approved these changes
Apr 8, 2025
Zeyber
requested changes
Apr 8, 2025
| it('Item Added to Cart Dialog', () => { | ||
| cy.visit(siteContextSelector.PRODUCT_PATH_2); | ||
| cy.get('cx-add-to-cart button[type=submit]').click(); | ||
| cy.get('cx-added-to-cart-dialog .cx-modal-content cx-cart-item') |
There was a problem hiding this comment.
cy.get('cx-added-to-cart-dialog .cx-modal-content cx-cart-item') is fine for making sure that the dialog has loaded first. But then we should run the scope of this test on the entire dialog DOM.
cy.get('cx-added-to-cart-dialog').a11yRunContinuumTest();
Zeyber
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://jira.tools.sap/browse/CXSPA-9645