Add Requisition Submission feature #20125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FollowTheFlo
commented
Mar 26, 2025
| @@ -39,7 +43,9 @@ export abstract class PunchoutFacade { | |||
| * Abstract method used to get Punchout Session Requisition data | |||
| * @param sessionId is the sesssion Id given by ARIBA via url param | |||
| */ | |||
| abstract getPunchoutSessionRequisition( | |||
| sessionId: string | |||
There was a problem hiding this comment.
No need to provide the sessionId as parameter, the facade method now gets it from the state (within punchoutStoreService ) directly.
FollowTheFlo
commented
Mar 26, 2025
| tap((punchoutRequisition) => { | ||
| this.listenAndSubmitForm(punchoutRequisition).subscribe({ | ||
| next: () => { | ||
| this.punchoutFormElement.nativeElement.submit(); |
There was a problem hiding this comment.
It is the only way to submit a POST form with 'action' attribute programmatically.
As long as nativeElement is not being modified, it is safe.
FollowTheFlo
commented
Mar 26, 2025
|
|
||
| protected isFormNativeElementAccessible(): Observable<boolean> { | ||
| // timer(0) wait for next Javascript event loop, this way DOM native elements becomes accessible. | ||
| return timer(0).pipe( |
There was a problem hiding this comment.
Reliable, I tested with all network speeds, nativeElement (line 45) is always accessible a expected, no race condition observed.
Matejk00
requested changes
Mar 27, 2025
integration-libs/punchout/components/punchout-requisition/punchout-requisition.component.ts
Outdated
Show resolved
Hide resolved
integration-libs/punchout/components/punchout-requisition/punchout-requisition.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMS cpnt: cart btns and requisition page
in Punchout-Requisition cpnt:
Fetch Requisition data from server
logout user
submit hidden form programmatically
in PunchoutButtons cpnt:
2 btns added on cart page
Only displayed when user is logged and punchoutSessionId exists.
click on btn redirect user to Requisition Page (which loads punchoutRequisition cpnt above)
Added translation