feat: (CXSPA-9820) - Add access continuum test for Applied Promotions #20281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-9820
|
| Run status |
|
| Run duration | 06m 12s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
238
|
| View all changes introduced in this branch ↗︎ | |
Pio-Bar
requested changes
May 12, 2025
Comment on lines
23
to
25
| cy.get('cx-mini-cart').click(); | ||
|
|
||
| cy.get('.cx-promotions').a11yRunContinuumTest(); |
There was a problem hiding this comment.
I see the intention is to run this on the cart page however, with this setup the test runs on PDP instead.
Pio-Bar
requested changes
May 15, 2025
| it('should show promotions on Cart page', () => { | ||
| cy.get('cx-mini-cart').click(); | ||
|
|
||
| cy.get('.cart-details-wrapper').should('exist'); |
There was a problem hiding this comment.
Suggested change
| cy.get('.cart-details-wrapper').should('exist'); | |
| cy.get('.cart-details-wrapper') |
|
|
||
| cy.get('.cart-details-wrapper').should('exist'); | ||
|
|
||
| cy.get('.cx-promotions').a11yRunContinuumTest(); |
There was a problem hiding this comment.
Selectors before the tests return more than one element. With our current setup Continuum will only scan the first one. Do we want to scan each or is this enough? 🤔
There was a problem hiding this comment.
There is only one cx-promotions in cart page, isn't there? 🤔
There was a problem hiding this comment.
There's two. Same goes for the previous one. In the 'add to cart' test only an empty div gets scanned.
There was a problem hiding this comment.
Updated the test for all promotions here.
Pio-Bar
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-9820
Add access continuum test for Applied Promotions