fix: pagination for OPF #20342
Closed
fix: pagination for OPF #20342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matejk00
commented
May 20, 2025
| @@ -822,7 +822,7 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = { | |||
| a11yOrganizationLinkableCells: true, | |||
| a11yTruncatedTextStoreFinder: true, | |||
| a11yTruncatedTextUnitLevelOrderHistory: false, | |||
| a11ySemanticPaginationLabel: true, | |||
| a11ySemanticPaginationLabel: false, | |||
There was a problem hiding this comment.
Functionality for OPF pagination is not working after this improvement: https://jira.tools.sap/browse/CXSPA-9517
[cxFocus] directive for some reason blocks a click event and pageChange method cannot be fired when customer click the pagination navigation.
@petarmarkov9449 do you have any insights into this behavior?
There was a problem hiding this comment.
After switching a a11ySemanticPaginationLabel flag seems that E2E test scenario started failing.
@Zeyber @petarmarkov9449 could you guys help here?
rmch91
approved these changes
May 20, 2025
rmch91
previously approved these changes
May 20, 2025
Merge Checks Failed |
spartacus
|
|||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-10188
|
| Run status |
|
| Run duration | 05m 47s |
| Commit |
|
| Committer | Mateusz Kolasa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
235
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/regression/product-search/product-search.core-e2e.cy.ts • 2 failed tests • B2C
| Test | Artifacts | |
|---|---|---|
| ... > should test pagination and display results |
Test Replay
Screenshots
Video
|
|
| ... > should test pagination and display results |
Test Replay
Screenshots
Video
|
|
cypress/e2e/ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR
| Test | Artifacts | |
|---|---|---|
| SSR > should render homepage |
Test Replay
Screenshots
Video
|
|
| SSR > should render PLP |
Test Replay
Screenshots
Video
|
|
| SSR > should render PDP |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: CXSPA-10188