-
Notifications
You must be signed in to change notification settings - Fork 8
Add augmentation and enrichment to keycloak pipeline #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
…nners Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any mention of sbomasm
in the README, while parlay
and snyk
are both discussed. Am I just missing the discussion of sbomasm
? Should we add some discussion to the README?
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Its included under ...
I'm not super happy with how this info is presented, which leads to details being missed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! Left a few minor changes/questions
Co-authored-by: Tieg Zaharia <[email protected]>
Co-authored-by: Tieg Zaharia <[email protected]>
Co-authored-by: Tieg Zaharia <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
It looks like there is a bug or something in parlay where it doesn't fill in supplier information for SPDX. A quick search found this open issue: snyk/parlay#76 I didn't see a fix in there, but I've only scanned pretty quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still running through some of the scorecard to see what the enrichments are doing. What would be the best way to handle that? Maybe merge this and then start opening issues that get PRs to fix? Or do we want to keep tackling stuff in this PR?
My vote would be merge, and then continue to improve through additional PRs. |
Co-authored-by: Douglas Dennis <[email protected]>
Signed-off-by: Ian Dunbar-Hall <[email protected]>
@idunbarh - Thanks for putting this together. This looks good to me. The |
…formation is not overridden Signed-off-by: Ian Dunbar-Hall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor comments.
Signed-off-by: Ian Dunbar-Hall <[email protected]>
…n 1 hour to run Signed-off-by: Ian Dunbar-Hall <[email protected]>
This PR adds the remaining capabilities to the Phase 1 Keycloak workflow.
This PR adds:
Additionally there are several tweaks:
You can find the SBOM Quality Scoring here.