-
Notifications
You must be signed in to change notification settings - Fork 8
Adding Harbor for Phase 2 workflow, primarily a Go project #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ricardo A. Reyes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Can you also add links to this to the README?
We can add the gitlab pipeline separately.
Signed-off-by: Ricardo A. Reyes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor change.
Co-authored-by: Tieg Zaharia <[email protected]>
Co-authored-by: Tieg Zaharia <[email protected]>
Co-authored-by: Tieg Zaharia <[email protected]>
fix typo Co-authored-by: Tieg Zaharia <[email protected]>
@vpetersson please review PR - changed the code to use the release publications, no longer using the repo |
@vpetersson @idunbarh
Please review this Phase 2 Workflow for Harbor
https://github.com/goharbor/harbor
I have tested this on my forked repo and it works, artifacts are uploaded to the artifacts to github's action artifact upload using v4.
Only action is to update the code with the git hash for the tag of the action for the artifact upload.