Fix(all): Remove dependency on @types/node (to reduce package size) #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBoudrias
force-pushed
the
pkg-size/remove-deps-on-types/node
branch
from
c7b798d
to
84b72c2
Compare
|
Added an e2e build suite to test |
SBoudrias
force-pushed
the
pkg-size/remove-deps-on-types/node
branch
6 times, most recently
from
279f2f2
to
ee1d1ac
Compare
SBoudrias
force-pushed
the
pkg-size/remove-deps-on-types/node
branch
from
2a29986
to
7ede9a9
Compare
SBoudrias
force-pushed
the
pkg-size/remove-deps-on-types/node
branch
from
e791488
to
21595aa
Compare
SBoudrias
force-pushed
the
pkg-size/remove-deps-on-types/node
branch
from
21595aa
to
e39fa8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1326
Not 100% how to test this effectively. Types passes in the repo, but that's kind of a low warranty for dependents.
Also, I think
@types/mute-streaminclude@types/node- so we'd probably also want to do away with it.