-
Notifications
You must be signed in to change notification settings - Fork 10
Adios2 update #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adios2 update #136
Conversation
(like ncomp, array size, data name etc) explicity to variables, now saving data to multi dimensional arrays.
adios2 data types given as string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. Can you post the output of bpls
on a mesh file created with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you.
I left one comment below.
Do we have any test cases for serial/parallel adios2 read/write?
assertions and comments.
Some modifications were done to update 1D arrays to 2D arrays.
on naming style.
@cwsmith I believe this is ready to merge when you return. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few small comments are below.
It looks like this is the current test case that writes then reads via the adios2 api:
Lines 668 to 671 in 09a5171
test_basefunc(adios2_io 1 ./adios2_io | |
${CMAKE_SOURCE_DIR}/meshes/unitbox_cutTriCube_1k.osh | |
${CMAKE_SOURCE_DIR}/meshes/plate_6elem.osh | |
output.bp) |
Would providing adios2osh
and osh2adios
converter utilities (as done for gmsh, exodus, etc.) be useful for the applications that need adios2 meshes?
Seegyoung has already added those utilities ( |
/runtests |
Test Result: success (details) |
If @jacobmerson is all set then I think this can be merged. |
This PR:
The updated output of
bpls
on a mesh written to an adios2 (.bp) file is given below. In this file,mesh/planes/0
is the pre name provided to the writer function.