-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master #327
base: main
Are you sure you want to change the base?
Master #327
Conversation
heya @comparecloud !!! Thank you so much for adding these in! Reviewing now and will get this merged in as soon as possible for the next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@comparecloud - Thanks for putting this together! Only feedback I would have are the following, everything else looks solid:
- It looks like the People API works in the context of the authenticated user and not at the organizational level, e.g. any contacts you create with
New-GSContact
would be added directly to theAdminEmail
account only. If that's accurate, can you add theUser
parameter and pass that toNew-GoogleService
? An example here would be onRemove-GSDriveFile
-- note the default value for$User
is the AdminEmail, the parameter is not mandatory (e.g. we want to default to the AdminEmail, we useResolve-Email
to convert shortcuts likeme
into the full AdminEmail value or append the domain if only the email name part is passed, etc. We also would need that as the additional parameter passed toNew-GoogleService
. - Check my comment on
New-GSContact
as it looks like an unset variable is used in the Verbose statement.
Once those are in, happy to get this merged! CC @FISHMANPET for visibility here.
$service = New-GoogleService @serviceParams | ||
} | ||
Process { | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is $PrimaryEmail
a remnant when testing? Not seeing it on the parameter list
Hey @comparecloud I realize it's been quite a while since you submitted this, but I'm pulling in old work to get ready for a new release. If you're still interested in this, could you look at the changes Nate requested? |
Per #53
Added functions to create GS contacts using the PeopleService API
Also modified the Contacts Get cmdlet adding the organization details (because I needed them)
A Contacts update cmdlet will come later