[WIP] Fix failing tests for Python 3.11 on MacOS#4252
Closed
bdbaddog wants to merge 7 commits intoSCons:masterfrom
Closed
[WIP] Fix failing tests for Python 3.11 on MacOS#4252bdbaddog wants to merge 7 commits intoSCons:masterfrom
bdbaddog wants to merge 7 commits intoSCons:masterfrom
Conversation
mwichmann
added
the
testsuite
… querying getconf ARG_MAX to find out actual limit and create arg longer than that, left default at previous lenght which was hardcoded
…this test is not consistently getting the path from tempdir or the realpath() of that, so create a regex with both (only for macOS)
Contributor
Author
|
Closing. Didn't make it to the finish line. I'll create a new PR when I get time to revisit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Items fixed:
Fix PathIsDirCreate() for python 3.11 on MacOS Catalina(at least) - This is in validator so fixes more than just test.
Contributor Checklist:
CHANGES.txt(and read theREADME.rst)