feat: provides api to register a callbacks #2055

saadmar · 2023-01-17T13:41:03Z

Extends the MessageProducer api to register a callback when using a non blocking producer.
Adds standard error logging for non blocking producers

We had a use case where a producer silently failed to produce a message (due to large size) and there was no trace for that as everything happens in a separate thread.

Another option for us could be blocking the thread and explicitly logging the exception, but we thought that could be good to have for all cases.

github-actions · 2023-01-17T14:12:46Z

Unit Test Results

0 tests ±0 0 ✔️ ±0 0s ⏱️ ±0s
0 suites ±0 0 💤 ±0
0 files ±0 0 ❌ ±0

Results for commit 2c10cef. ± Comparison against base commit 934f37b.

♻️ This comment has been updated with latest results.

JoergSiebahn · 2023-01-17T14:33:02Z

...rver-kafka/src/test/java/org/sdase/commons/server/kafka/producer/KafkaMessageProducerIT.java

+              assertThat(out.capturedLines())
+                  .anyMatch(l -> l.contains(statement))
+                  .anyMatch(
+                      l ->
+                          l.contains(
+                              "An error occurred while producing a message with key k to the topic test-topic."));


Above it is documented, that the callback is called when the message is sent. In my understanding that means success, but here you verify that the callback is called and that an error occurred. That seems to be different to the documentation. Can you explain that?