Skip to content

Conversation

@YellowFlora
Copy link
Contributor

@YellowFlora YellowFlora commented Dec 3, 2025

Adds configuration parameter to enable the output of a histogram or percentiles for the http_server_requests metrics

@YellowFlora YellowFlora requested a review from a team as a code owner December 3, 2025 09:28
@YellowFlora
Copy link
Contributor Author

YellowFlora commented Dec 3, 2025

implements the idea #4166

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Next minor release will be 8.2.0, Show Release Notes

8.2.0 (2026-01-07)

Features

  • server-prometheus: add configurable options for histogramm and percentiles for the http_server_requests metrics in the PrometheusBundle (375ce50)
  • starter: add PrometheusBundle configuration to SdaPlatformBundle and into SdaPlatformConfiguration (5198b25)

Bug Fixes

  • add additional application/json accept header to issuer client (36e0970)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Test Results

1 208 files  +12  1 208 suites  +12   41m 1s ⏱️ + 1m 56s
1 596 tests + 1  1 582 ✅ + 1  14 💤 ±0  0 ❌ ±0 
6 748 runs  +20  6 686 ✅ +20  62 💤 ±0  0 ❌ ±0 

Results for commit 2dbdca3. ± Comparison against base commit 36e0970.

This pull request removes 4 and adds 5 tests. Note that renamed tests count towards both.
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [4] {processes=[p-c1, p-c2], tenant-id=[t-c]}, {processes=[p-n3, p-n4], tenant-id=[]}, EXTEND, {processes=[p-c1, p-c2, p-n3, p-n4], tenant-id=[t-c]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [5] {tenant-id=[t-c]}, {processes=[p-n]}, EXTEND, {processes=[p-n], tenant-id=[t-c]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [8] {tenant-id=[t-c]}, {processes=[p-n], tenant-id=[t-n]}, KEEP, {processes=[p-n], tenant-id=[t-c]}
org.sdase.commons.server.dropwizard.metadata.MetadataContextMergeIntegrationTest ‑ [9] {processes=[p-c], tenant-id=[t-c]}, {tenant-id=[t-n]}, REPLACE, {processes=[p-c], tenant-id=[t-n]}
org.sdase.commons.server.prometheus.PrometheusBundleWithRequestHistogramIT ‑ shouldTrackRequestsAndAddHistogram()
org.sdase.commons.server.prometheus.PrometheusBundleWithSpecificRequestPercentilesIT ‑ shouldTrackRequestsAndAddQuantile()
org.sdase.commons.starter.PrometheusBuilderTest ‑ withCustomPrometheusConfiguration()
org.sdase.commons.starter.PrometheusBuilderTest ‑ withDefaultPrometheusConfiguration()
org.sdase.commons.starter.PrometheusBuilderTest ‑ withDefaultPrometheusConfigurationWithoutConfiguration()

♻️ This comment has been updated with latest results.

@YellowFlora YellowFlora force-pushed the feat/scm-1711 branch 2 times, most recently from 20c046a to d859bcf Compare January 5, 2026 14:10
Copy link
Contributor

@JoergSiebahn JoergSiebahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments.

@YellowFlora
Copy link
Contributor Author

Hello @ahoeing,

the feature is now implemented so far. Could you also take a last look if that is usable for you like this?

JoergSiebahn
JoergSiebahn previously approved these changes Jan 6, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

@YellowFlora YellowFlora merged commit 971edf9 into main Jan 7, 2026
25 of 26 checks passed
@YellowFlora YellowFlora deleted the feat/scm-1711 branch January 7, 2026 08:41
@SDABot
Copy link
Contributor

SDABot commented Jan 7, 2026

🎉 This PR is included in version 8.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@SDABot SDABot added the released label Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants