-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add optional histogram or percentiles for http_server_requests metrics #4176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fd0b57b to
7c72315
Compare
|
implements the idea #4166 |
Next minor release will be 8.2.0, Show Release Notes8.2.0 (2026-01-07)Features
Bug Fixes
|
Test Results1 208 files +12 1 208 suites +12 41m 1s ⏱️ + 1m 56s Results for commit 2dbdca3. ± Comparison against base commit 36e0970. This pull request removes 4 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
20c046a to
d859bcf
Compare
JoergSiebahn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments.
...ns-server-prometheus/src/main/java/org/sdase/commons/server/prometheus/PrometheusBundle.java
Outdated
Show resolved
Hide resolved
...ns-server-prometheus/src/main/java/org/sdase/commons/server/prometheus/PrometheusBundle.java
Show resolved
Hide resolved
...rc/test/java/org/sdase/commons/server/prometheus/PrometheusBundleWithRequestHistogramIT.java
Show resolved
Hide resolved
sda-commons-server-prometheus/src/test/resources/prometheus-test-config-histogram.yaml
Outdated
Show resolved
Hide resolved
...ns-server-prometheus/src/main/java/org/sdase/commons/server/prometheus/PrometheusBundle.java
Outdated
Show resolved
Hide resolved
...ns-server-prometheus/src/main/java/org/sdase/commons/server/prometheus/PrometheusBundle.java
Show resolved
Hide resolved
|
Hello @ahoeing, the feature is now implemented so far. Could you also take a last look if that is usable for you like this? |
0ae4086 to
4c49521
Compare
4c49521 to
8196ab3
Compare
8196ab3 to
09777a4
Compare
09777a4 to
f4b1a79
Compare
…percentiles for the http_server_requests metrics in the PrometheusBundle
…e and into SdaPlatformConfiguration
f4b1a79 to
2dbdca3
Compare
|
|
🎉 This PR is included in version 8.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |



Adds configuration parameter to enable the output of a histogram or percentiles for the http_server_requests metrics