fix: add additional application/json accept header to issuer client

[pathec]

No description provided.

[YellowFlora]

Good catch! That is really a problem, for Authentication Provider who enforce the OIDC specification and don't allow other accept headers.

Our tests also uses the JSON as response type and never checked for the correct ACCEPT header.

Could you add a check for the ACCEPT header into the Wiremock stub configuration for the token Endpoint in the different OidcClientTest classes? (package: sda-commons-client-jersey/src/test/java/org/sdase/commons/client/jersey/oidc/)

for example in OidcClientTest itself:

    WIRE.stubFor(
        post("/token")
            .withHeader(ACCEPT, equalTo(APPLICATION_FORM_URLENCODED + "," + APPLICATION_JSON)) //or similar check 
            .willReturn(
                aResponse()
                    .withStatus(200)
                    .withHeader(CONTENT_TYPE, APPLICATION_JSON)
                    .withBodyFile("fixtures/tokenResponse.json")));

so that it is checked, that now both headers are always send to the Authorization Provider?

[pathec]

@YellowFlora thanks for the review. Please have a look again

[YellowFlora]

Looks good!

Its only missing in OidcRequestFilterTest; the stub configuration is at the bottom there

[YellowFlora]

👍

(i will check sonar tmr morning, not sure yet why it doesnt work)

[pathec]

Hi @YellowFlora have you already looked into the sonar issue?

[YellowFlora]

Hi @pathec we downgraded Sonar now, so it should work now

[SDABot]

🎉 This PR is included in version 8.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀