Skip to content

Update Dropwizard to V5 #4218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
YellowFlora wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Update Dropwizard to V5 #4218

YellowFlora wants to merge 16 commits into from

Conversation

@YellowFlora
Copy link
Contributor

@YellowFlora YellowFlora commented Jan 12, 2026

  • fix(deps): update depedencies for dropwizard 5 update
  • fix(sda-commons-client-jersey): remove checkerframework checker
  • fix(sda-commons-dependency-check): add jna as exception for the no duplicate classes rule
  • fix(sda-commons-server-cors): migrate from jetty CrossOriginFilter to CrossOriginHandler
  • test(sda-commons-server-dropwizard): remove environment variables that are no longer available in dropwizard 5 from availability test
  • test(sda-commons-server-kafka): migrate to updated prometheus metrics
  • fix(sda-commons-server-openapi): migrate from jetty CrossOriginFilter to CrossOriginHandler
  • test(sda-commons-server-opentelemetry): migrate jetty AsyncContextState
  • test(sda-commons-server-security): migrate jetty ErrorHandler
  • test(sda-commons-server-weld-testing): migrate Weld tests to Weld 6
  • test(sda-commons-starter): migrate to updated prometheus metrics
  • test(sda-commons-server-s3): update OpenTelemetry s3 attribute names
  • fix(sda-commons-shared-tracing): remove deprecated RequestTracing
  • fix(sda-commons-server-prometheus): update from prometheus simpleclient to prometheus-metrics-core

@YellowFlora YellowFlora mentioned this pull request Jan 12, 2026
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

Next patch release will be 8.2.1, Show Release Notes

8.2.1 (2026-01-13)

Bug Fixes

  • deps: bump ch.qos.logback:logback-core from 1.5.21 to 1.5.24 (f7573b5)
  • deps: update depedencies for dropwizard 5 update (f1ad48e)
  • sda-commons-client-jersey: remove checkerframework checker (a6a560a)
  • sda-commons-dependency-check: add jna as exception for the no duplicate classes rule (84e9bb3)
  • sda-commons-server-cors: migrate from jetty CrossOriginFilter to CrossOriginHandler (4fa9dc0)
  • sda-commons-server-openapi: migrate from jetty CrossOriginFilter to CrossOriginHandler (724c2e2)
  • sda-commons-server-prometheus: update from prometheus simpleclient to prometheus-metrics-core (9102a2f)
  • sda-commons-shared-tracing: remove deprecated RequestTracing (d4e9991)

@YellowFlora
fix(deps): update depedencies for dropwizard 5 update
f1ad48e 
BREAKING CHANGE
@YellowFlora
fix(sda-commons-client-jersey): remove checkerframework checker
a6a560a
@YellowFlora
fix(sda-commons-dependency-check): add jna as exception for the no du…
84e9bb3 
…plicate classes rule
@YellowFlora
fix(sda-commons-server-cors): migrate from jetty CrossOriginFilter to…
4fa9dc0 
… CrossOriginHandler
@YellowFlora
test(sda-commons-server-dropwizard): remove environment variables tha…
4b113b2 
…t are no longer available in dropwizard 5 from availability test
@YellowFlora
test(sda-commons-server-kafka): migrate to updated prometheus metrics
dcbe110
@YellowFlora
fix(sda-commons-server-openapi): migrate from jetty CrossOriginFilter…
724c2e2 
… to CrossOriginHandler
@YellowFlora
test(sda-commons-server-opentelemetry): migrate jetty AsyncContextState
c500cb0
@YellowFlora
test(sda-commons-server-security): migrate jetty ErrorHandler
39e8fab
@YellowFlora
test(sda-commons-server-weld-testing): migrate Weld tests to Weld 6
dae541e
@YellowFlora
test(sda-commons-starter): migrate to updated prometheus metrics
120f054
@YellowFlora
test(sda-commons-server-s3): update OpenTelemetry s3 attribute names
c0edaea
@YellowFlora
fix(sda-commons-shared-tracing): remove deprecated RequestTracing
d4e9991 
BREAKING CHANGE
@YellowFlora
fix(sda-commons-server-prometheus): update from prometheus simpleclie…
9102a2f 
…nt to prometheus-metrics-core

WARNING: Some parts needs to be rolled back later
@YellowFlora YellowFlora force-pushed the feat/update_dropwizard_to_5 branch from 5fc2432 to 9102a2f Compare January 12, 2026 08:13
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

Test Results

1 208 files  ±    0  1 208 suites  ±0   19m 43s ⏱️ - 20m 59s
1 099 tests  -   501    857 ✅  -   729  11 💤  -  3  231 ❌ +231 
4 492 runs   - 2 256  3 518 ✅  - 3 168  50 💤  - 12  924 ❌ +924 

For more details on these failures, see this check.

Results for commit f7573b5. ± Comparison against base commit 971edf9.

This pull request removes 678 and adds 177 tests. Note that renamed tests count towards both. 
org.example.KafkaDoubleAppTest ‑ shouldProvideHealthChecks()
org.example.KafkaDoubleAppTest ‑ shouldReadFromSourceAndWriteToTarget()
org.sdase.commons.client.jersey.ApiClientConfigurationTest ‑ disableGzip()
org.sdase.commons.client.jersey.ApiClientConfigurationTest ‑ dontSubmitMetadataContextInExternalClient()
org.sdase.commons.client.jersey.ApiClientConfigurationTest ‑ enableChunkedEncoding()
org.sdase.commons.client.jersey.ApiClientConfigurationTest ‑ enableGzipForRequests()
org.sdase.commons.client.jersey.ApiClientConfigurationTest ‑ submitMetadataContextInPlatformClient()
org.sdase.commons.client.jersey.ApiClientTest ‑ addConsumerToken()
org.sdase.commons.client.jersey.ApiClientTest ‑ addCustomFiltersToExternalClient()
org.sdase.commons.client.jersey.ApiClientTest ‑ addCustomFiltersToPlatformClient()
…

org.example.KafkaDoubleAppTest ‑ initializationError
org.sdase.commons.client.jersey.ApiClientConfigurationTest ‑ initializationError
org.sdase.commons.client.jersey.ApiClientTest ‑ initializationError
org.sdase.commons.client.jersey.ApiClientTimeoutTest ‑ initializationError
org.sdase.commons.client.jersey.ApiClientWithoutConsumerTokenTest ‑ initializationError
org.sdase.commons.client.jersey.ClientConfiguredProxyTest ‑ initializationError
org.sdase.commons.client.jersey.ClientProxyTest ‑ initializationError
org.sdase.commons.client.jersey.ClientTlsUpgradeTest ‑ initializationError
org.sdase.commons.client.jersey.GenericClientTimeoutTest ‑ initializationError
org.sdase.commons.client.jersey.JerseyClientBundleNoopTracingTest ‑ initializationError
…

♻️ This comment has been updated with latest results.

YellowFlora and others added 2 commits January 12, 2026 10:35
@YellowFlora
chore(ci): add org.glassfish.jersey.ext:jersey-micrometer into trivy …
dbefe1e 
…list
@dependabot @YellowFlora
fix(deps): bump ch.qos.logback:logback-core from 1.5.21 to 1.5.24
f7573b5 
Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.5.21 to 1.5.24.
- [Release notes](https://github.com/qos-ch/logback/releases)
- [Commits](qos-ch/logback@v_1.5.21...v_1.5.24)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-core
  dependency-version: 1.5.24
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 13, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@YellowFlora