Reuse project settings in dtos - #615
Open
Slartibartfass2 wants to merge 7 commits into
Open
Conversation
1 task
Code Coverage
|
Slartibartfass2
force-pushed
the
refactor/614-refactor-reuse-project-settings-in-dtos
branch
from
September 3, 2026 17:16
b35955a to
88d6540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #614
What I have made
This is a step-by-step refactoring:
ProjectSettingsDTO and replaced the settings properties inProjectwith itUserSettingswith singleProjectSettingspropertyUserSettingsis now also stored in theUserDTOProjectSettingsinstead ofUserSettingstocreateProjectrepo callgetUserSettingsrepo call and use settings from the user DTO directlyIn
DataBuilderI didn't change the parameters to pass a settings object in favor of a more simple fixture creation.Checklist
Either tick or cross out the items that do not apply (using ~~example text~~) and give a reason why the item does not apply.
Author
[ ] I have updatedAGENTS.mdif the changes affect project structure, commands, tooling, or conventions[ ] I have manually tested my changes[ ] I have added tests that prove my fix is effective or that my feature worksReviewer