Skip to content

Reuse project settings in dtos - #615

Open
Slartibartfass2 wants to merge 7 commits into
developfrom
refactor/614-refactor-reuse-project-settings-in-dtos
Open

Reuse project settings in dtos#615
Slartibartfass2 wants to merge 7 commits into
developfrom
refactor/614-refactor-reuse-project-settings-in-dtos

Conversation

@Slartibartfass2

@Slartibartfass2 Slartibartfass2 commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Closes #614

What I have made

This is a step-by-step refactoring:

  1. Added ProjectSettings DTO and replaced the settings properties in Project with it
  2. Replaced default project settings properties in UserSettings with single ProjectSettings property
  3. UserSettings is now also stored in the User DTO
  4. Only pass ProjectSettings instead of UserSettings to createProject repo call
  5. Remove getUserSettings repo call and use settings from the user DTO directly

In DataBuilder I didn't change the parameters to pass a settings object in favor of a more simple fixture creation.

Checklist

Either tick or cross out the items that do not apply (using ~~example text~~) and give a reason why the item does not apply.

Author

  • I have updated the documentation accordingly and commented my code
    • [ ] I have updated AGENTS.md if the changes affect project structure, commands, tooling, or conventions
  • [ ] I have manually tested my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works

Reviewer

  • I have checked the changes against the requirements

@Slartibartfass2 Slartibartfass2 self-assigned this Aug 30, 2026
@Slartibartfass2 Slartibartfass2 linked an issue Aug 30, 2026 that may be closed by this pull request
1 task
@Slartibartfass2
Slartibartfass2 requested a review from mowi12 August 30, 2026 17:24
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Code Coverage

Overall Project 98.21% -0.05% 🍏
Files changed 95.95% 🍏

File Coverage
UserTable.kt 100% 🍏
User.kt 100% 🍏
UserSettings.kt 100% 🍏
ProjectResponse.kt 100% 🍏
ProjectSettings.kt 100% 🍏
ReviewService.kt 100% 🍏
UserService.kt 100% 🍏
UserTableRepo.kt 99.9% 🍏
ProjectTableRepo.kt 99.89% 🍏
ProjectService.kt 99.86% 🍏
FetcherService.kt 99.63% 🍏
ProjectTable.kt 97.19% 🍏
FetcherOrchestrator.kt 96.91% 🍏
Project.kt 91.58% 🍏
UpdateProjectSettingRequest.kt 71.43% -23.81%

@Slartibartfass2
Slartibartfass2 force-pushed the refactor/614-refactor-reuse-project-settings-in-dtos branch from b35955a to 88d6540 Compare September 3, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Refactor]: Reuse project settings in DTOs

1 participant