Merge pull request #168 from SEMOSAN/fix/#167-withdraw-fk-constraint

[Fix] 회원탈퇴 시 course_difficulty_feedbacks FK 제약 위반 500 에러 수정

Author: pooreumjung

src/main/java/com/semosan/api/domain/hiking/repository/CourseDifficultyFeedbackRepository.java

@@ -2,8 +2,21 @@
 
 import com.semosan.api.domain.hiking.entity.CourseDifficultyFeedback;
 import org.springframework.data.jpa.repository.JpaRepository;
+import org.springframework.data.jpa.repository.Modifying;
+import org.springframework.data.jpa.repository.Query;
+import org.springframework.data.repository.query.Param;
+
+import java.util.List;
 
 public interface CourseDifficultyFeedbackRepository extends JpaRepository<CourseDifficultyFeedback, Long> {
 
     boolean existsByHikingRecord_Id(Long hikingRecordId);
+
+    @Modifying(clearAutomatically = true)
+    @Query("DELETE FROM CourseDifficultyFeedback cdf WHERE cdf.user.id = :userId")
+    void deleteByUserId(@Param("userId") Long userId);
+
+    @Modifying(clearAutomatically = true)
+    @Query("DELETE FROM CourseDifficultyFeedback cdf WHERE cdf.hikingRecord.id IN :hikingRecordIds")
+    void deleteByHikingRecordIdIn(@Param("hikingRecordIds") List<Long> hikingRecordIds);
 }

src/main/java/com/semosan/api/domain/user/service/UserService.java

@@ -2,6 +2,7 @@
 
 import com.semosan.api.common.exception.GeneralException;
 import com.semosan.api.common.status.ErrorStatus;
+import com.semosan.api.domain.hiking.repository.CourseDifficultyFeedbackRepository;
 import com.semosan.api.domain.hiking.repository.HikingMemberRepository;
 import com.semosan.api.domain.hiking.repository.HikingRecordRepository;
 import com.semosan.api.domain.mountain.repository.CourseLikeRepository;
@@ -38,6 +39,7 @@ public class UserService {
     private final ReviewRepository reviewRepository;
     private final HikingMemberRepository hikingMemberRepository;
     private final HikingRecordRepository hikingRecordRepository;
+    private final CourseDifficultyFeedbackRepository courseDifficultyFeedbackRepository;
     private final NotificationRepository notificationRepository;
     private final DefaultNicknameGenerator defaultNicknameGenerator;
     private final NicknamePolicy nicknamePolicy;
@@ -147,9 +149,11 @@ private void deleteUserChildRecords(Long userId) {
         mountainLikeRepository.deleteByUser_Id(userId);
         courseLikeRepository.deleteByUser_Id(userId);
         reviewRepository.deleteByUser_Id(userId);
+        courseDifficultyFeedbackRepository.deleteByUserId(userId);
         List<Long> recordIdsToDelete = hikingRecordRepository.findRecordIdsOnlyParticipatedByUser(userId);
         hikingMemberRepository.deleteByUser_Id(userId);
         if (!recordIdsToDelete.isEmpty()) {
+            courseDifficultyFeedbackRepository.deleteByHikingRecordIdIn(recordIdsToDelete);
             hikingRecordRepository.deleteAllByIdInBatch(recordIdsToDelete);
         }
         notificationRepository.deleteAllByUserId(userId);

src/test/java/com/semosan/api/domain/user/service/UserServiceTest.java

@@ -1,5 +1,6 @@
 package com.semosan.api.domain.user.service;
 
+import com.semosan.api.domain.hiking.repository.CourseDifficultyFeedbackRepository;
 import com.semosan.api.domain.hiking.repository.HikingMemberRepository;
 import com.semosan.api.domain.hiking.repository.HikingRecordRepository;
 import com.semosan.api.domain.mountain.repository.CourseLikeRepository;
@@ -17,6 +18,7 @@
 import com.semosan.api.domain.user.repository.UserRepository;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.InOrder;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
@@ -27,6 +29,7 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.Mockito.inOrder;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
@@ -57,6 +60,9 @@ class UserServiceTest {
     @Mock
     private HikingRecordRepository hikingRecordRepository;
 
+    @Mock
+    private CourseDifficultyFeedbackRepository courseDifficultyFeedbackRepository;
+
     @Mock
     private NotificationRepository notificationRepository;
 
@@ -173,8 +179,10 @@ void withdrawUserDeletesUserChildRecordsAndSoftDeletesUser() {
 
         verify(mountainLikeRepository).deleteByUser_Id(1L);
         verify(reviewRepository).deleteByUser_Id(1L);
+        verify(courseDifficultyFeedbackRepository).deleteByUserId(1L);
         verify(hikingRecordRepository).findRecordIdsOnlyParticipatedByUser(1L);
         verify(hikingMemberRepository).deleteByUser_Id(1L);
+        verify(courseDifficultyFeedbackRepository).deleteByHikingRecordIdIn(List.of(10L, 11L));
         verify(hikingRecordRepository).deleteAllByIdInBatch(List.of(10L, 11L));
         verify(notificationRepository).deleteAllByUserId(1L);
         verify(userOnboardingRepository).deleteByUser_Id(1L);
@@ -187,5 +195,11 @@ void withdrawUserDeletesUserChildRecordsAndSoftDeletesUser() {
         assertThat(user.getNickname()).isNull();
         assertThat(user.getOauthId()).isEqualTo("WITHDRAWN:1:TEST");
         assertThat(user.getOnboardingStatus()).isEqualTo(OnboardingStatus.INCOMPLETE);
+
+        InOrder deleteOrder = inOrder(courseDifficultyFeedbackRepository, hikingRecordRepository);
+        deleteOrder.verify(courseDifficultyFeedbackRepository).deleteByUserId(1L);
+        deleteOrder.verify(hikingRecordRepository).findRecordIdsOnlyParticipatedByUser(1L);
+        deleteOrder.verify(courseDifficultyFeedbackRepository).deleteByHikingRecordIdIn(List.of(10L, 11L));
+        deleteOrder.verify(hikingRecordRepository).deleteAllByIdInBatch(List.of(10L, 11L));
     }
 }