[Fix] 세모피드 이모지 알림 메시지에 이모지 문자 표시#195
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 세모피드 이모지 반응 알림 시 enum 이름이 그대로 노출되던 문제를 해결하기 위해, 각 이모지 타입에 대응하는 문자열을 정의하고 이를 알림 메시지 생성 과정에 반영하여 사용자 경험을 개선했습니다. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the SemoFeedEmojiType enum to map each type to its corresponding emoji character and modifies SemoFeedNotificationService to send the actual emoji instead of the enum name. While the change is straightforward, it will cause existing tests in SemoFeedNotificationServiceTest to fail because they still expect the enum name (e.g., 'FIRE') instead of the emoji character. The test assertions should be updated accordingly.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "actorName", reactor.displayName(), | ||
| "semoFeedId", semoFeed.getId(), | ||
| "emojiType", emojiType.name() | ||
| "emojiType", emojiType.getEmoji() |
There was a problem hiding this comment.
[P2] 이모지 변경으로 인해 기존 테스트 코드가 실패합니다.
SemoFeedNotificationServiceTest.java 파일의 sendEmojiNotificationSendsToSemoFeedAuthor 테스트에서 emojiType 검증 시 여전히 "FIRE" 문자열을 기대하고 있어, 이 변경 사항이 적용되면 테스트가 실패하게 됩니다.
테스트 코드의 검증 부분을 "🔥" 또는 SemoFeedEmojiType.FIRE.getEmoji()를 기대하도록 수정해야 합니다.
대상 테스트 코드 (SemoFeedNotificationServiceTest.java):
// 변경 전
&& params.get("emojiType").equals("FIRE")
// 변경 후
&& params.get("emojiType").equals(SemoFeedEmojiType.FIRE.getEmoji())References
- 변경된 비즈니스 로직에 맞게 테스트 코드가 올바르게 작동하는지 확인하고 관리해야 합니다. (link)
🧾 요약
🔗 이슈
✨ 변경 내용
SemoFeedEmojiTypeenum에 각 타입별 이모지 문자 필드 추가 (FIRE → 🔥, HEART → ❤️, CONGRATS → 🎉, LAUGH → 😂).name()대신.getEmoji()사용✅ 확인