Skip to content

[Fix] 세모피드 이모지 알림 메시지에 이모지 문자 표시#195

Merged
pooreumjung merged 1 commit into
developfrom
fix/#194-semofeed-emoji-notification
Jun 4, 2026
Merged

[Fix] 세모피드 이모지 알림 메시지에 이모지 문자 표시#195
pooreumjung merged 1 commit into
developfrom
fix/#194-semofeed-emoji-notification

Conversation

@pooreumjung

Copy link
Copy Markdown
Member

🧾 요약

  • 세모피드 이모지 반응 알림에 enum 이름(HEART, FIRE 등)이 텍스트로 노출되던 문제를 이모지 문자로 교체

🔗 이슈

✨ 변경 내용

  • SemoFeedEmojiType enum에 각 타입별 이모지 문자 필드 추가 (FIRE → 🔥, HEART → ❤️, CONGRATS → 🎉, LAUGH → 😂)
  • 알림 파라미터 전달 시 .name() 대신 .getEmoji() 사용

✅ 확인

  • 빌드 OK
  • 테스트 OK

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0dbec94-d111-4cfa-a41d-d0799008452a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#194-semofeed-emoji-notification

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pooreumjung pooreumjung self-assigned this Jun 4, 2026
@pooreumjung pooreumjung added the bug Something isn't working label Jun 4, 2026
@pooreumjung
pooreumjung merged commit c00b7ce into develop Jun 4, 2026
3 checks passed
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

세모피드 이모지 반응 알림 시 enum 이름이 그대로 노출되던 문제를 해결하기 위해, 각 이모지 타입에 대응하는 문자열을 정의하고 이를 알림 메시지 생성 과정에 반영하여 사용자 경험을 개선했습니다.

Highlights

  • 이모지 데이터 구조화: SemoFeedEmojiType enum에 각 타입별 이모지 문자를 매핑하는 필드를 추가하고 Lombok을 적용했습니다.
  • 알림 메시지 형식 개선: 알림 서비스에서 이모지 타입의 이름 대신 실제 이모지 문자가 전송되도록 로직을 수정했습니다.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SemoFeedEmojiType enum to map each type to its corresponding emoji character and modifies SemoFeedNotificationService to send the actual emoji instead of the enum name. While the change is straightforward, it will cause existing tests in SemoFeedNotificationServiceTest to fail because they still expect the enum name (e.g., 'FIRE') instead of the emoji character. The test assertions should be updated accordingly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

"actorName", reactor.displayName(),
"semoFeedId", semoFeed.getId(),
"emojiType", emojiType.name()
"emojiType", emojiType.getEmoji()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

[P2] 이모지 변경으로 인해 기존 테스트 코드가 실패합니다.

SemoFeedNotificationServiceTest.java 파일의 sendEmojiNotificationSendsToSemoFeedAuthor 테스트에서 emojiType 검증 시 여전히 "FIRE" 문자열을 기대하고 있어, 이 변경 사항이 적용되면 테스트가 실패하게 됩니다.

테스트 코드의 검증 부분을 "🔥" 또는 SemoFeedEmojiType.FIRE.getEmoji()를 기대하도록 수정해야 합니다.

대상 테스트 코드 (SemoFeedNotificationServiceTest.java):

// 변경 전
&& params.get("emojiType").equals("FIRE")

// 변경 후
&& params.get("emojiType").equals(SemoFeedEmojiType.FIRE.getEmoji())
References
  1. 변경된 비즈니스 로직에 맞게 테스트 코드가 올바르게 작동하는지 확인하고 관리해야 합니다. (link)

@howooyeon
howooyeon deleted the fix/#194-semofeed-emoji-notification branch June 5, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] 세모피드 이모지 알림 메시지에서 enum 이름 대신 이모지 문자로 표시

1 participant