[Feat] #20 트래킹 세션 종료 시 하이킹 기록 생성 by JangInho · Pull Request #54 · SEMOSAN/SEMOSAN_BE

JangInho · 2026-05-19T12:45:45Z

🧾 요약

트래킹 세션 종료 시 수집된 GPS 통계 데이터를 기반으로 HikingRecord를 자동 생성하도록 구현했습니다.

🔗 이슈

close [feat] 산행 기록 계산 및 저장 #20

✨ 변경 내용

트래킹 세션 종료 시 HikingRecord 자동 생성 로직 추가
HikingRecord 엔티티 확장
세션 통계 계산 보강 및 GPS 포인트 처리 흐름 정리

기타사항

DB 마이그레이션 스크립트(002_hiking_record_extension.sql) 추가한건 머지할때 빼겠습니다 !
complete() 시 Redis Stream race 로 마지막 GPS 점 누락 / 빈 Hash 빈 기록 생성 가능
HikingRecord max_altitude · calories NOT NULL + 0 fallback → nullable 화 필요

✅ 확인

빌드 OK
테스트 OK

Summary by CodeRabbit

New Features
- Tracking sessions now automatically generate and save hiking records upon completion, eliminating manual entry
- Expanded tracking metrics including distance, elevation gain/loss, paused time, session timestamps, and maximum altitude are now captured and stored for each activity

coderabbitai · 2026-05-19T12:45:52Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b120ef86-32a9-4f91-aff3-0238a1bfa395

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main feature: automatic creation of hiking records when a tracking session ends, which aligns with the primary objective of the PR.
Linked Issues check	✅ Passed	The PR implements key requirements from issue `#20`: distance calculation via tracking stats [TrackingSessionStatsService adds distance tracking], elevation change [ascent/descent computed], elapsed time [duration calculated from startedAt/endedAt minus paused seconds], and DB persistence [HikingRecord created and saved at session termination]. Polyline storage is not addressed but is marked incomplete in the issue.
Out of Scope Changes check	✅ Passed	All changes are within scope: HikingRecord entity extended to track GPS-derived metrics, TrackingSessionResponse updated to expose hiking record linkage, TrackingSessionService orchestrates record creation, TrackingSessionStatsService computes required metrics, and the DB migration supports the new schema. No unrelated changes detected.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/#20-tracking-record-finalize

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/main/resources/db/migration/002_hiking_record_extension.sql`:
- Around line 45-53: Add a DB-level uniqueness guard so each tracking_session_id
maps to at most one hiking_records row: in the migration that alters table
hiking_records (currently adding fk_hiking_records_tracking_session and creating
idx_hiking_records_tracking_session), also create a UNIQUE constraint or UNIQUE
INDEX on hiking_records(tracking_session_id) (e.g. name it
uq_hiking_records_tracking_session or
unique_idx_hiking_records_tracking_session) using the same IF NOT EXISTS pattern
so retries/concurrent runs are safe; ensure the UNIQUE creation follows/avoids
conflict with the existing fk_hiking_records_tracking_session and
idx_hiking_records_tracking_session.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ce8896c-99e6-4ec1-86de-f1a680da581b

📥 Commits

Reviewing files that changed from the base of the PR and between c0509d0 and 1b1d692.

📒 Files selected for processing (5)

src/main/java/com/semosan/api/domain/hiking/entity/HikingRecord.java
src/main/java/com/semosan/api/domain/tracking/dto/response/TrackingSessionResponse.java
src/main/java/com/semosan/api/domain/tracking/service/TrackingSessionService.java
src/main/java/com/semosan/api/domain/tracking/service/TrackingSessionStatsService.java
src/main/resources/db/migration/002_hiking_record_extension.sql

coderabbitai · 2026-05-19T12:51:45Z

+        ALTER TABLE hiking_records
+            ADD CONSTRAINT fk_hiking_records_tracking_session
+            FOREIGN KEY (tracking_session_id) REFERENCES tracking_sessions(id);
+    END IF;
+END$$;
+
+-- 6) 조회 인덱스 (HikingRecord 로 트래킹 세션 역방향 찾을 일은 거의 없으나, 디버그/분석용)
+CREATE INDEX IF NOT EXISTS idx_hiking_records_tracking_session
+    ON hiking_records (tracking_session_id);


⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Enforce one-record-per-session at DB level.

tracking_session_id currently has FK + index only, so duplicate hiking_records per session are still possible under retries/concurrency. Add a unique constraint (or unique index) on tracking_session_id to protect data integrity.

Suggested migration adjustment

DO $$ BEGIN IF NOT EXISTS ( SELECT 1 FROM information_schema.table_constraints WHERE table_name = 'hiking_records' AND constraint_name = 'fk_hiking_records_tracking_session' ) THEN ALTER TABLE hiking_records ADD CONSTRAINT fk_hiking_records_tracking_session FOREIGN KEY (tracking_session_id) REFERENCES tracking_sessions(id); END IF; END$$; -CREATE INDEX IF NOT EXISTS idx_hiking_records_tracking_session - ON hiking_records (tracking_session_id); +CREATE UNIQUE INDEX IF NOT EXISTS uq_hiking_records_tracking_session + ON hiking_records (tracking_session_id) + WHERE tracking_session_id IS NOT NULL;

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

ALTER TABLE hiking_records

ADD CONSTRAINT fk_hiking_records_tracking_session

FOREIGN KEY (tracking_session_id) REFERENCES tracking_sessions(id);

END IF;

END$$;

-- 6) 조회 인덱스 (HikingRecord 로 트래킹 세션 역방향 찾을 일은 거의 없으나, 디버그/분석용)

CREATE INDEX IF NOT EXISTS idx_hiking_records_tracking_session

ON hiking_records (tracking_session_id);

ALTER TABLE hiking_records

ADD CONSTRAINT fk_hiking_records_tracking_session

FOREIGN KEY (tracking_session_id) REFERENCES tracking_sessions(id);

END IF;

END$$;

-- 6) 조회 인덱스 (HikingRecord 로 트래킹 세션 역방향 찾을 일은 거의 없으나, 디버그/분석용)

CREATE UNIQUE INDEX IF NOT EXISTS uq_hiking_records_tracking_session

ON hiking_records (tracking_session_id)

WHERE tracking_session_id IS NOT NULL;

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/main/resources/db/migration/002_hiking_record_extension.sql` around lines 45 - 53, Add a DB-level uniqueness guard so each tracking_session_id maps to at most one hiking_records row: in the migration that alters table hiking_records (currently adding fk_hiking_records_tracking_session and creating idx_hiking_records_tracking_session), also create a UNIQUE constraint or UNIQUE INDEX on hiking_records(tracking_session_id) (e.g. name it uq_hiking_records_tracking_session or unique_idx_hiking_records_tracking_session) using the same IF NOT EXISTS pattern so retries/concurrent runs are safe; ensure the UNIQUE creation follows/avoids conflict with the existing fk_hiking_records_tracking_session and idx_hiking_records_tracking_session.

pooreumjung

고생하셨습니다,,!

pooreumjung · 2026-05-20T07:27:51Z

+
+-- 6) 조회 인덱스 (HikingRecord 로 트래킹 세션 역방향 찾을 일은 거의 없으나, 디버그/분석용)
+CREATE INDEX IF NOT EXISTS idx_hiking_records_tracking_session
+    ON hiking_records (tracking_session_id);


여기 unique 제약 필요할 듯!

추가완료

pooreumjung · 2026-05-20T07:28:29Z

-    /** 등산 중 도달한 최고 고도 (m) */
+    /** 등산 중 도달한 최고 고도 (m). */
    @Column(name = "max_altitude", nullable = false)
    private Double altitude;


이거 columne name이랑 entity 필드 명이랑 불일치

수정완료!

pooreumjung · 2026-05-20T07:29:55Z

-        return TrackingSessionResponse.from(session);
+
+        TrackingSessionStatsService.Stats stats = statsService.getStats(sessionId);
+        HikingRecord record = HikingRecord.fromTrackingSession(


stats의 pointCount가 0이면 통계 데이터 없음으로 간주하고 경고 처리나 예외 처리하면 좋을 듯!

좋습니다 일단 예외는 안넣고 로그만 넣었습니다

pooreumjung · 2026-05-20T07:30:25Z

@@ -0,0 +1,53 @@
+-- =====================================================================


파일명도 바꿔야 할듯

수정 완료

[Feat] #19 트래킹 GPS 머지

…record-finalize # Conflicts: # src/main/java/com/semosan/api/domain/tracking/service/TrackingSessionService.java

- 002_hiking_record_extension.sql 삭제, V9__extend_hiking_record.sql 신규 작성 - 기존 002 내용 + tracking_session_id UNIQUE 제약 (세션당 기록 1건 강제) - HikingRecord.altitude 필드명을 컬럼명과 정합되게 maxAltitude 로 변경 (DTO 응답 키 호환 위해 HikingRecordSummaryResponse 필드명은 유지) - TrackingSessionService.complete: stats.pointCount == 0 일 때 경고 로그 추가

coderabbitai Bot reviewed May 19, 2026

View reviewed changes

JangInho added 2 commits May 19, 2026 22:14

chore: HikingRecord 확장 및 마이그레이션 추가

d3ce2f1

feat: 트래킹 세션 종료 시 HikingRecord 자동 생성

7a65656

JangInho force-pushed the feat/#20-tracking-record-finalize branch from 1b1d692 to 7a65656 Compare May 19, 2026 13:15

pooreumjung reviewed May 20, 2026

View reviewed changes

howooyeon assigned JangInho May 20, 2026

howooyeon added the enhancement New feature or request label May 20, 2026

JangInho and others added 3 commits May 21, 2026 20:08

Merge pull request #73 from SEMOSAN/feat/#19-tracking-gps

43242da

[Feat] #19 트래킹 GPS 머지

Merge remote-tracking branch 'origin/develop' into feat/#20-tracking-…

b412b69

…record-finalize # Conflicts: # src/main/java/com/semosan/api/domain/tracking/service/TrackingSessionService.java

JangInho merged commit b61348d into feat/#19-tracking-gps May 21, 2026
1 check passed

This was referenced May 24, 2026

[Feat] 라이브 액티비티 기능 추가 #99

Merged

[Feat] 트래킹 안내난이도 후기 등록 추가 #122

Merged

coderabbitai Bot mentioned this pull request Jun 3, 2026

[Feat] 등산 기록 상세 조회에 등산 당시 기온 정보 추가 #181

Merged

2 tasks

		@@ -0,0 +1,53 @@
		-- =====================================================================

Uh oh!

Conversation

JangInho commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧾 요약

🔗 이슈

✨ 변경 내용

기타사항

✅ 확인

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

pooreumjung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JangInho commented May 19, 2026 •

edited

Loading

coderabbitai Bot commented May 19, 2026 •

edited

Loading