Allow overriding protected methods on sfMusic and sfSoundStream #397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394.
Implements overriding for protected methods in
sfMusic
andsfSoundStream
by using the pattern described here.The Chunk struct was also updated since the data types were different from the ones used in the C++ library:
Additionally,
ci.yml
was updated so that a newer version of CMake would be fetched. mirroring the current code in the SFML repo. Without this, CI would fail due to an unsupported old version (< 3.5) being fetched.