Updates on EVN mode and logging#2
Open
ykzhang112233 wants to merge 297 commits into
Open
Conversation
shaoguangleo
approved these changes
Nov 27, 2023
| AIPS_NUMBER = 248 | ||
| antname = 'VLBA' # Antenna order for FITLD | ||
|
|
||
| AIPS_NUMBER = 606 |
Contributor
There was a problem hiding this comment.
I suggest the AIPS_NUMBER setting xxx by default.
Because everyone has their own NO, and if it was set for a special number, there is a danger to conflict other people's data.
we can check this setting in the main.py, if it was set to xxx, then we can remind the user to change it.
| antname = 'VLBA' # Antenna order for FITLD | ||
|
|
||
| AIPS_NUMBER = 606 | ||
| antname = 'EVN' # Antenna order for FITLD |
Contributor
There was a problem hiding this comment.
I suggest we can change this line to the following:
antname = 'EVN' # Antenna order for FITLD
# can be VLBA/EVN/...
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize the original code.
Add EVN mode. Some extra input parameters are required in the config.py
Updated the logging output. Generating logging_config.py to set the overall logging as logger. Add some necessary logger info in run_task. More logger.info are waitting to be added. I will make this in the near future.