Skip to content

Updated setup.py and pyproject.toml #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenwalton wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updated setup.py and pyproject.toml #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6292c44
Updating pyproject.toml
stevenwalton Nov 1, 2025
81709bb
Merging Setup.py
stevenwalton Nov 1, 2025
ea14c58
Ran ruff
stevenwalton Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 31 additions & 7 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
[project]
name = "NATTEN"
description = "Neighborhood Attention Extension"
dynamic = ["version"]
readme = {file = "docs/README_pypi.md", content-type = "text/markdown"}
license = "MIT"
license-files = ["LICENSE"]
requires-python = ">=3.9"
authors = [
{name = "Ali Hassani"}
{name = "NATTEN Project", email="info@natten.org"}
]
maintainers = [
{name = "Ali Hassani"}
{name = "NATTEN Project", email="info@natten.org"}
]

dynamic = ["version"]
keywords = [
"attention",
"sparse attention",
Expand All @@ -18,20 +23,39 @@ keywords = [
"artificial intelligence",
"ai",
]
requires-python = ">=3.9"
readme = {file = "docs/README_pypi.md", content-type = "text/markdown"}

dependencies = [
"torch>=2.8.0",
Copy link
Collaborator

@alihassanijr alihassanijr Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"torch>=2.8.0",
"torch",

Can we relax this for now and just make it any version of torch?
Some pypi versions are stupid and will error out if the system constraints have locked the torch version.
The best part is that the version requirements are also met.

But anyway, we do technically support 2.7, even 2.6.
If folks aren't using Flex, we can probably go even as far back as 2.0. They'd have to compile it themselves of course.

Copy link
Author

@stevenwalton stevenwalton Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to local stage and placing comments for additional clarity

]

# Classifiers for better searching pypi
# https://pypi.org/classifiers/
classifiers = [
"Development Status :: 4 - Beta",
"Environment :: GPU",
"Environment :: GPU :: NVIDIA CUDA",
"Intended Audience :: Science/Research",
"Intended Audience :: Developers",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Topic :: Scientific/Engineering",
"Topic :: Scientific/Engineering :: Artificial Intelligence"
]

[project.urls]
Homepage = "https://natten.org"
Documentation = "https://natten.org"
Repository = "https://github.com/SHI-Labs/NATTEN.git"
Changelog = "https://github.com/SHI-Labs/NATTEN/blob/main/CHANGELOG.md"
Issues = "https://github.com/SHI-Labs/NATTEN/issues"
Download = "https://whl.natten.org/"

[build-system]
requires = [
"setuptools >= 64",
"torch >= 2.7",
"cmake >= 4.0",
"torch >= 2.8",
Copy link
Collaborator

@alihassanijr alihassanijr Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"torch >= 2.8",
"torch",

Same here. Let's accept any version of torch, and just raise warnings/errors in setup/cmake if it's unsupported... I really don't want to trust pypi to do the right thing here.

"cmake >= 3.2",
Copy link
Author

@stevenwalton stevenwalton Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to review our versioning here

"build >= 1.3.0"
]
build-backend = "setuptools.build_meta"
Expand Down
Loading