Stabilize recommendation fallback metadata and small runtime/front-end fixes#4
Open
SHREESHANTH99 wants to merge 1 commit intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fallback_sourcefrom internal metadata instead of brittle human-readable text.Description
backend/src/routes/recommendationRoutes.jsto resolve multiple env names intoPYTHON_RECOMMEND_API_URLandPYTHON_HEALTH_URL, addREQUEST_TIMEOUT_MS, a staticSTATIC_FALLBACK_RECOMMENDATIONSlist, Jikan/popular fallbacks, and tag fallback items with_fallbackSourcewhile addingextractFallbackSourceandsanitizeFallbackItemshelpers to derivefallback_sourceand remove internal fields before responses.verifyToken, computeeffectiveUserId, returnsource/fallback_sourceconsistently, and use the helpers when falling back to static/Jikan data.user.idvs_idlookup inbackend/server.jsandSocketContext.jsx, addaltattribute inNavbar.jsx, fix cube scaling inThreeScene.jsx, stabilize hooks and request handling inSimilarAnime.jsx,AIRecommendations.jsx,ResetPassword.jsx,AuthContext.jsx(exchange token shape and profile resolution), and switch many local API URLs to the5001backend port.buildscript toGENERATE_SOURCEMAP=false react-scripts build, remove internal metadata from API outputs, and add small eslint-disable comments where necessary to avoid noisy hook warnings.Testing
node --check backend/src/routes/recommendationRoutes.jsand it passed syntax validation (success).npm run build(GENERATE_SOURCEMAP=false react-scripts build) and the frontend production build completed successfully (compiled assets produced).Codex Task