Replace deprecated from_string with make_address_v4#68
Open
BasketsAlaaf wants to merge 1 commit intoSICKAG:masterfrom
Open
Replace deprecated from_string with make_address_v4#68BasketsAlaaf wants to merge 1 commit intoSICKAG:masterfrom
BasketsAlaaf wants to merge 1 commit intoSICKAG:masterfrom
Conversation
Replace `boost::asio::ip::address_v4::from_string()` with `boost::asio::ip::make_address_v4()` for IPv4 address parsing. The `from_string()` method was deprecated in Boost 1.66 in favor of the free function `make_address_v4()`. This change ensures compatibility with newer Boost versions and avoids deprecation warnings during compilation. Signed-off-by: Matthias Schoepfer <matthias.schoepfer@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace deprecated
boost::asio::ip::address_v4::from_string()calls with the modernboost::asio::ip::make_address_v4()free function for IPv4 address parsing.Why this change is needed:
from_string()was deprecated in Boost 1.66Changes:
SickSafetyscanners.hpp(sensor_ip, interface_ip, host_ip parsing)SickSafetyscanners.cpp(dynamic host_ip parameter callback)Test Case
Steps to verify the changes:
from_string()appearhost_ipparameter at runtimeExpected result: Node builds without deprecation warnings and correctly parses all IP addresses