Add SICK_SAFETYSCANNERS_BASE_BUILD_SHARED_LIBS option to control shar… #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed/static Changes: Introduce SICK_SAFETYSCANNERS_BASE_BUILD_SHARED_LIBS option (ON = shared, OFF = static). Default derives from BUILD_SHARED_LIBS to preserve backward compatibility. Resolve library type via internal _sick_build_shared and avoid forcing cache writes. Make FetchContent usage deterministic (parent can set option before FetchContent_MakeAvailable to reliably select static builds).
Collaborator
|
Thank you for the contribution! Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the build configuration in
CMakeLists.txtto provide more flexible and explicit control over whether thesick_safetyscanners_baselibrary is built as a shared or static library. The changes improve compatibility with different build systems and make it easier for downstream projects to select the desired library type.Build configuration improvements:
SICK_SAFETYSCANNERS_BASE_BUILD_SHARED_LIBSto allow explicit control over buildingsick_safetyscanners_baseas a shared or static library, with sensible defaults based onBUILD_SHARED_LIBSfor backward compatibility.POSITION_INDEPENDENT_CODEfor static builds to ensure compatibility.