Deprecate the pylint+safety CI tests job #338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest safety CLI has a dedicated GitHub Action one can use instead (the 'safety check' has been deprecated and 'safety scan' requires a user). Pylint is not longer being used in general in favor of ruff.
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the pylint and safety CI test jobs in favor of using pre-commit hooks and a dedicated GitHub Action for safety.
- Disable the execution of
pylintandsafetytests by updating default values to false in workflow files. - Update documentation to include a deprecation notice and mark related parameters as deprecated.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/workflows/ci_tests.md | Added deprecation warnings and updated parameter defaults. |
| .github/workflows/ci_tests.yml | Changed default values for run_pylint and run_safety to false. |
| .github/workflows/_local_ci_tests.yml | Set run_safety to false and removed outdated commented options. |
Comments suppressed due to low confidence (1)
docs/workflows/ci_tests.md:244
- [nitpick] There appear to be duplicate parameter definitions for deprecated CI jobs in this file. Consider consolidating these entries into a single table to improve clarity for users.
| `run_pylint` | **_Deprecated_** Run the `pylint` test job. | No | `false` | _boolean_ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
=======================================
Coverage 85.37% 85.37%
=======================================
Files 12 12
Lines 937 937
=======================================
Hits 800 800
Misses 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update deprecation warning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest safety CLI has a dedicated GitHub Action one can use instead (the 'safety check' has been deprecated and 'safety scan' requires a user).
Pylint is not longer being used in general in favor of ruff.
AI Summary
This pull request deprecates the
pylintandsafetyjobs in favor of usingpre-commithooks and a dedicated GitHub Action forsafety. It updates configuration files and documentation to reflect this change, including setting the default values for these jobs tofalseand marking related inputs as deprecated.Deprecation of
pylintandsafetyjobs:.github/workflows/_local_ci_tests.yml: Disabled thesafetyjob by settingrun_safetytofalseand removed thesafety_optionsconfiguration..github/workflows/ci_tests.yml: Changed the default values forrun_pylintandrun_safetytofalse. [1] [2]Documentation updates:
docs/workflows/ci_tests.md: Added a deprecation notice for thepylintandsafetyjobs, recommending the use ofpre-commithooks and thesafetyGitHub Action.docs/workflows/ci_tests.md: Updated the default values forrun_pylintandrun_safetytofalsein the parameter table and marked related inputs as deprecated. [1] [2]