Skip to content

Conversation

@leonardehrenfried
Copy link
Contributor

Hello there, this is my first PR to this repo so be gentle. :)

I hit a problem with Estimated/RecordedCall's StopPointRef value in an Italian feed. It took a bit of back and forth to figure out what exactly it refers to but we got an agreement in the end: https://public.3.basecamp.com/p/TcEEP5WrNZJPBxrJU9GAjint

I would like to document what I learned so others can benefit from it.

Unfortunately I have no clue if I put the information into the correct place and whether the formatting is correct.

Therefore I request a rigorous review.

@ue71603 @Aurige

@skinkie
Copy link
Contributor

skinkie commented Nov 27, 2024

Don't think basecamp links or profile implementations should be placed in here, hence it requires some rephrasing.

@leonardehrenfried
Copy link
Contributor Author

cc @rcavaliere

Aurige
Aurige previously approved these changes Jun 27, 2025
@Aurige Aurige changed the base branch from master to integration June 27, 2025 07:45
@Aurige Aurige dismissed their stale review June 27, 2025 07:45

The base branch was changed.

@leonardehrenfried
Copy link
Contributor Author

Sorry, I seem to be unable to teach my editor to use the correct indentation and I also seem to have stripped emtpy line endings.

Is there an automatic formatting tool available?

Copy link
Collaborator

@TuThoThai TuThoThai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reworked since the phrasing does not fit the group. Explanation: QUAYs must be referenced using QuayRef. Also, there is a bigger conversation about making clearer the StopPointRef

@leonardehrenfried
Copy link
Contributor Author

Thanks for the review. I see that you assigned other people.

Presumably they will provide the precise documentation to use. Is this correct?

@TuThoThai
Copy link
Collaborator

@leonardehrenfried
Yes, it is correct. As it is a group effort, we will try to find some wording to propose and advance this PR together. 😄

@TuThoThai TuThoThai added this to the later milestone Sep 24, 2025
@haeckerbaer haeckerbaer modified the milestones: later, v2.3 Sep 24, 2025
@TuThoThai TuThoThai added the Needs CEN documentation Update These require CEN documentation update to match XSD & examples label Nov 9, 2025
@haeckerbaer haeckerbaer changed the base branch from integration to 2.3 December 19, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs CEN documentation Update These require CEN documentation update to match XSD & examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants