-
Notifications
You must be signed in to change notification settings - Fork 22
Clarify XXXCall's StopPointRef #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.3
Are you sure you want to change the base?
Conversation
|
Don't think basecamp links or profile implementations should be placed in here, hence it requires some rephrasing. |
|
cc @rcavaliere |
|
Sorry, I seem to be unable to teach my editor to use the correct indentation and I also seem to have stripped emtpy line endings. Is there an automatic formatting tool available? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be reworked since the phrasing does not fit the group. Explanation: QUAYs must be referenced using QuayRef. Also, there is a bigger conversation about making clearer the StopPointRef
|
Thanks for the review. I see that you assigned other people. Presumably they will provide the precise documentation to use. Is this correct? |
|
@leonardehrenfried |
Hello there, this is my first PR to this repo so be gentle. :)
I hit a problem with Estimated/RecordedCall's
StopPointRefvalue in an Italian feed. It took a bit of back and forth to figure out what exactly it refers to but we got an agreement in the end: https://public.3.basecamp.com/p/TcEEP5WrNZJPBxrJU9GAjintI would like to document what I learned so others can benefit from it.
Unfortunately I have no clue if I put the information into the correct place and whether the formatting is correct.
Therefore I request a rigorous review.
@ue71603 @Aurige