Skip to content

Made DOE deterministic, recovered missing input files and fixed a bg#157

Open
zurabksmlp wants to merge 1 commit into
masterfrom
doe_files_recovery
Open

Made DOE deterministic, recovered missing input files and fixed a bg#157
zurabksmlp wants to merge 1 commit into
masterfrom
doe_files_recovery

Conversation

@zurabksmlp

Copy link
Copy Markdown
Collaborator
  1. Made DOE deterministic so regression tests 34 to 45 should become reproducible.
    The master files have been updated.

  2. Created missing DOE specs for tests 145,146,205 and added respective master files.
    These new DOE specs are:
    regr_smlp/grids/doe_two_levels_opt.csv
    regr_smlp/grids/explore_doe_two_levels.csv

  3. Added random seed in DOE related regressions tests, in smlp_regr.csv where it was missing.

  4. Fixed a bug in single-objective optimization calls detected in tests 145, 146, and 205.

  5. Code changes are in:
    smlp_refine.py
    smlp_doe.py
    smlp_flows.py
    smlp_optimize.py

@zurabksmlp zurabksmlp requested a review from fbrausse June 30, 2026 13:39
@mdmitry1

mdmitry1 commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator
  1. In my regression now only two tests are crashing: Test104 and Test107
  2. As happened with PR fix for support for eta constraints in spec file #152, I was not able to reproduce all results in the PR.
    In this case I've got different results for Test146.
    Therefore I believe we need to wait until @fbrausse will run testing on his machine.
  3. Masters for the below files are probably not updated, as content diff has been reported in my run:
Test9_smlp_toy_num_resp_mult_smlp_toy_num_resp_mult_pred_labeled_args_config.json Failed -> content diff
Test31_smlp_toy_num_resp_mult_args_config.json Failed -> content diff
Test87_smlp_toy_num_resp_mult_rerun_model_config.json Failed -> content diff
Test92_smlp_toy_num_resp_mult_rerun_model_config.json Failed -> content diff
Test123_smlp_toy_basic.txt Failed -> content diff
test20_model_rerun_model_config.json Failed -> content diff
test19_model_rerun_model_config.json Failed -> content diff
test22_model_rerun_model_config.json Failed -> content diff
test24_model_rerun_model_config.json Failed -> content diff
test26_model_rerun_model_config.json Failed -> content diff
test63_model_rerun_model_config.json Failed -> content diff
test69_model_rerun_model_config.json Failed -> content diff
test101_model_rerun_model_config.json Failed -> content diff
test103_model_rerun_model_config.json Failed -> content diff
test110_model_rerun_model_config.json Failed -> content diff
test113_model_rerun_model_config.json Failed -> content diff

Build 80
Regression results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants