Skip to content

Specify DOI for SMPTE refs #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 23, 2025
Merged

Specify DOI for SMPTE refs #314

merged 16 commits into from
Sep 23, 2025

Conversation

@SteveLLamb
Copy link
Member

@SteveLLamb SteveLLamb commented Mar 4, 2025 •
edited
Loading

Closes #313

@SteveLLamb SteveLLamb requested a review from palemieux March 4, 2025 18:56
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Review links

Clean
Clean PDF
Redline to current draft
Redline to most recent edition

palemieux
palemieux requested changes Mar 4, 2025
View reviewed changes
@SteveLLamb SteveLLamb requested a review from palemieux March 4, 2025 20:07
palemieux
palemieux reviewed Mar 5, 2025
View reviewed changes
palemieux
palemieux reviewed Mar 5, 2025
View reviewed changes
palemieux
palemieux reviewed Mar 5, 2025
View reviewed changes
palemieux
palemieux reviewed Mar 5, 2025
View reviewed changes
Copy link
Member

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

SteveLLamb and others added 2 commits March 5, 2025 09:10
@SteveLLamb @palemieux
update undated ref text
8437d9c 
Co-authored-by: Pierre-Anthony Lemieux <[email protected]>
@SteveLLamb @palemieux
update wording to AG-29
e02937c 
Co-authored-by: Pierre-Anthony Lemieux <[email protected]>
@SteveLLamb SteveLLamb requested a review from palemieux March 5, 2025 17:12
@SteveLLamb SteveLLamb changed the title Specify AG-29 for SMPTE refs Specify DOI for SMPTE refs Apr 15, 2025
@SteveLLamb SteveLLamb requested a review from ERyan71258 April 15, 2025 17:16
@SteveLLamb
Copy link
Member Author

SteveLLamb commented Apr 15, 2025

@ERyan71258 as per our DOI, I have specified that usage for SMPTE docs.

@ERyan71258
Copy link
Collaborator

ERyan71258 commented Apr 15, 2025

Where in the document is the specified usage for SMPTE documents? I see the following:
image

Should the example instead use a real-life SMPTE document?

@SteveLLamb
Copy link
Member Author

SteveLLamb commented Apr 15, 2025 •
edited
Loading

@ERyan71258 #314 (comment)

added in 24d6c25

palemieux
palemieux requested changes Aug 22, 2025
View reviewed changes
@SteveLLamb @palemieux
update verbiage
296b925 
Co-authored-by: Pierre-Anthony Lemieux <[email protected]>
palemieux
palemieux reviewed Aug 22, 2025
View reviewed changes
@SteveLLamb
Copy link
Member Author

SteveLLamb commented Aug 22, 2025

Screenshot 2025-08-22 at 11 09 48 AM

As discussed offline, putting in a <span class="doi"> now generates a DOI link as well (see screencap). I have also added in validation for more than one being added.

@SteveLLamb SteveLLamb requested a review from palemieux August 22, 2025 18:33
palemieux
palemieux requested changes Aug 22, 2025
View reviewed changes
Copy link
Member

@palemieux palemieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a unit test and/or update https://github.com/SMPTE/html-pub-template to make it works.

@SteveLLamb
Copy link
Member Author

SteveLLamb commented Aug 22, 2025

Can you create a unit test and/or update https://github.com/SMPTE/html-pub-template to make it works.

Of course! Done at ee1a4a8

@SteveLLamb SteveLLamb requested a review from palemieux August 22, 2025 20:31
@SteveLLamb SteveLLamb merged commit c06766e into main Sep 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palemieux palemieux palemieux approved these changes

@ERyan71258 ERyan71258 Awaiting requested review from ERyan71258

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Specify how to use SMPTE references

4 participants

@SteveLLamb @ERyan71258 @palemieux