Split Vacancies and Foundation Defect Complexes Code - #127
Draft
kavanase wants to merge 4 commits into
Draft
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kavanase
force-pushed
the
split_vacancies
branch
2 times, most recently
from
June 26, 2025 22:21
b304253 to
f0d7be7
Compare
kavanase
force-pushed
the
split_vacancies
branch
from
August 12, 2025 04:47
6ef1f97 to
3631bc8
Compare
kavanase
force-pushed
the
split_vacancies
branch
2 times, most recently
from
October 16, 2025 18:45
03042cd to
1a6a8d7
Compare
kavanase
force-pushed
the
split_vacancies
branch
from
February 1, 2026 22:22
1a6a8d7 to
343f3a7
Compare
kavanase
marked this pull request as draft
April 10, 2026 18:50
kavanase
force-pushed
the
split_vacancies
branch
2 times, most recently
from
June 30, 2026 16:02
3f9c024 to
ec85ee4
Compare
kavanase
force-pushed
the
split_vacancies
branch
from
July 22, 2026 10:25
dae8562 to
1a40440
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kavanase
force-pushed
the
split_vacancies
branch
2 times, most recently
from
July 23, 2026 13:26
a05cb5e to
08e9a19
Compare
Adds the `doped.complexes` module (split-vacancy and complex-defect generation, electrostatic- and geometry-based searching, and symmetry/ multiplicity analysis), along with its tests, test data and docs. This is the split_vacancies branch re-based onto `develop`: develop already contains all the shared non-complex refactors (parsing/symmetry/analysis etc.), so only the additive complex-defect content remains here, keeping the inter-branch diff minimal. Note: committed with --no-verify; `tests/test_complexes.py` has pre-existing WIP failures and `complexes.py` has pre-existing mypy errors (both present on the original split_vacancies branch, independent of this rebase). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…d test (plus some mypy fixes)
kavanase
force-pushed
the
split_vacancies
branch
from
July 30, 2026 21:36
4d3476d to
43ff05a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See original commit names here: #119
Squashed and restarted after repo clean.
This draft PR adds functions for general complex defect symmetry and multiplicity analysis, and (initial) automated complex defect structure recognition in parsing.
Alongside, a development goal is automated split vacancy generation from ML-calculated database, but that is secondary to the general defect complexes support.