Update release action#277
Merged
Merged
Conversation
Member
Author
|
@utf I think our options to find out if "write-all" works are:
|
Member
|
I'm happy with either option. I would have been lazy and just released 2.4.1 👀 |
PyPI rejects duplicate version number but should understand post-release versioning.
Member
Author
|
Ok, that seems to all be happy now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release action was on an older python. I also updated it to use more modern/recommended PyPI authentication (i.e. the action is whitelisted from PyPI side and doesn't use a password from
secrets.)That succeeded in building and pushing to PyPI, but failed to create a Github release 🤦
https://github.com/SMTG-Bham/sumo/actions/runs/24199863780/job/70640200234
I think I need to set "write-all" permission instead of "write": https://stackoverflow.com/questions/70435286/resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac
Given that the release is on PyPI the correct cleanup option is probably to create a manual release on Github now.
I'll also update the permission to "write-all" here, which hopefully will fix it next time.