Skip to content

Update release action#277

Merged
ajjackson merged 5 commits into
masterfrom
release-2.4.0
Apr 9, 2026
Merged

Update release action#277
ajjackson merged 5 commits into
masterfrom
release-2.4.0

Conversation

@ajjackson
Copy link
Copy Markdown
Member

The release action was on an older python. I also updated it to use more modern/recommended PyPI authentication (i.e. the action is whitelisted from PyPI side and doesn't use a password from secrets.)

That succeeded in building and pushing to PyPI, but failed to create a Github release 🤦

https://github.com/SMTG-Bham/sumo/actions/runs/24199863780/job/70640200234

I think I need to set "write-all" permission instead of "write": https://stackoverflow.com/questions/70435286/resource-not-accessible-by-integration-on-github-post-repos-owner-repo-ac

Given that the release is on PyPI the correct cleanup option is probably to create a manual release on Github now.

I'll also update the permission to "write-all" here, which hopefully will fix it next time.

@ajjackson
Copy link
Copy Markdown
Member Author

@utf I think our options to find out if "write-all" works are:

  • Test the permissions fix by creating a "post release" version 2.4.0.post1
    • This creates a version on PyPI but indicates that it isn't meaningfully different from 2.4.0; so people updating from 2.3 will get 2.4.0.post1 but people already on 2.4.0 don't get updated.
    • Then we edit/delete the new release created on github by the action. Or:
  • Wait until next release and find out if it worked then.

@utf
Copy link
Copy Markdown
Member

utf commented Apr 9, 2026

I'm happy with either option. I would have been lazy and just released 2.4.1 👀

PyPI rejects duplicate version number but should understand
post-release versioning.
@ajjackson
Copy link
Copy Markdown
Member Author

Ok, that seems to all be happy now!

@ajjackson ajjackson merged commit be4def2 into master Apr 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants