build: Remove uneeded buid requirements#46
Merged
WolfgangWaltenberger merged 1 commit intoSModelS:developfrom Mar 1, 2025
Merged
build: Remove uneeded buid requirements#46WolfgangWaltenberger merged 1 commit intoSModelS:developfrom
WolfgangWaltenberger merged 1 commit intoSModelS:developfrom
Conversation
Contributor
matthewfeickert
commented
Feb 28, 2025
- The build requirements are the necessary build tooling. pip is an installer front end and not a build system.
* The build requirements are the necessary build tooling. pip is an installer front end and not a build system.
Contributor
Author
|
@WolfgangWaltenberger This is ready for review. |
Contributor
Author
|
The CI is failing from which is unrealted to this PR. |
matthewfeickert
commented
Feb 28, 2025
| @@ -1,3 +1,3 @@ | |||
| [build-system] | |||
| requires = ["setuptools>=61.0","pip"] | |||
| requires = ["setuptools>=61.0"] | |||
Contributor
Author
There was a problem hiding this comment.
To clarify a bit, the build-system.requires are tools that get installed from PyPI into a temporary virtual environment that the build happens in which is then cleaned up and removed. So pip isn't something that should get added here (unless you had to intentionally downgrade pip, but at that point you have what amounts to a broken build and you should fix your build instead).
c.f. https://learn.scientific-python.org/development/guides/packaging-classic/#pep-517518-support-high-priority for more high level details or read PEP 517/518.
Member
|
Removed the pip dependency further down in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.