Skip to content

build: Remove uneeded buid requirements#46

Merged
WolfgangWaltenberger merged 1 commit intoSModelS:developfrom
matthewfeickert:fix/remove-uneeded
Mar 1, 2025
Merged

build: Remove uneeded buid requirements#46
WolfgangWaltenberger merged 1 commit intoSModelS:developfrom
matthewfeickert:fix/remove-uneeded

Conversation

@matthewfeickert
Copy link
Contributor

  • The build requirements are the necessary build tooling. pip is an installer front end and not a build system.

* The build requirements are the necessary build tooling. pip is an installer
  front end and not a build system.
@matthewfeickert
Copy link
Contributor Author

@WolfgangWaltenberger This is ready for review.

@matthewfeickert
Copy link
Contributor Author

The CI is failing from

FAILED: <class 'smodels.experiment.exceptions.SModelSExperimentError'>,"Error 404: could not fetch 'https://smodels.github.io/database/official303' from server: 'Not Found'"

which is unrealted to this PR.

@@ -1,3 +1,3 @@
[build-system]
requires = ["setuptools>=61.0","pip"]
requires = ["setuptools>=61.0"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify a bit, the build-system.requires are tools that get installed from PyPI into a temporary virtual environment that the build happens in which is then cleaned up and removed. So pip isn't something that should get added here (unless you had to intentionally downgrade pip, but at that point you have what amounts to a broken build and you should fix your build instead).

c.f. https://learn.scientific-python.org/development/guides/packaging-classic/#pep-517518-support-high-priority for more high level details or read PEP 517/518.

@WolfgangWaltenberger WolfgangWaltenberger merged commit 145bd44 into SModelS:develop Mar 1, 2025
4 of 15 checks passed
@WolfgangWaltenberger
Copy link
Member

Removed the pip dependency further down in the code.

@matthewfeickert matthewfeickert deleted the fix/remove-uneeded branch March 1, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants