Protect event loop from user callback exceptions#91
Open
VolkerChristian wants to merge 1 commit intomasterfrom
Open
Protect event loop from user callback exceptions#91VolkerChristian wants to merge 1 commit intomasterfrom
VolkerChristian wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
core::Event::dispatchthat catches all exceptions fromonEventand forwards them to a new recovery hook:EventReceiver::onEventException(std::exception_ptr). (files:src/core/Event.cpp,src/core/EventReceiver.h)EventReceiver::onEventExceptionthat logs the exception (standard and non-standard) using the logging facility. (file:src/core/EventReceiver.cpp)src/core/DescriptorEventReceiver.h,src/core/DescriptorEventReceiver.cpp)SocketReader/SocketWriterpaths to route exceptions into the existing error handling path by invokingonStatus(EIO), which triggers the established connection teardown flow and avoids leaving only one side disabled. (files:src/core/socket/stream/SocketReader.{h,cpp},src/core/socket/stream/SocketWriter.{h,cpp})Testing
git diff --checkto verify no whitespace or diff errors, which passed.cmake -S . -B buildto validate project configuration; configuration failed in this environment due to a missing external dependency (nlohmann_json>=3.11) unrelated to these code changes, so a full build was not completed here.Codex Task