Conversation
… string, startup health visibility
3019b3c to
0ca0937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🟢 (us) london 185.26.11.91 | 🟡 chicago ...) now logs only on change (dedup vialastLoggedPeersState); emoji legend printed once automatically on firstRefresh()instead of being an explicit public call(us)annotation: gossippeerInfonow carriesisSelf boolset at build time fromSelfIP; fixed missingSelfIPwire-up ingossip.Optionsso(us)actually appears in the state stringinternal/localpackage with its own poll interval (default: 2s), decoupled from the gossip poll loop; logs on every health state transition including startup ("waiting for 45s healthy streak before eligible for failover")!firstSamplesuppression so the "waiting for minimum duration" log fires at startup and after any unhealthy period symmetrically; removed now-deadsampledOncefieldcheckForActivePeer()removed: redundant after gossip state string already captures active/passive/us on every changedelinquent_slot_distance_overridewarnings: added startup warning when override value is below 128 (Agave default), recommending--health-check-slot-distance <value>on the validator to keep thresholds aligned; corrected stale README note that health check default was 150 (it was aligned to 128 in Agave v2.0 via the sameDELINQUENT_VALIDATOR_SLOT_DISTANCEconstant); added source URLs for bothrpc-client-types/src/request.rsandvalidator/src/commands/run/args/json_rpc_config.rsmanager.gowarning block that incorrectly flagged override values above 128 (opposite direction) and cited the outdated 150 default