Add Windows compatibility by using an older GC#5
Open
bardo84 wants to merge 1 commit intoSOM-st:masterfrom
Open
Add Windows compatibility by using an older GC#5bardo84 wants to merge 1 commit intoSOM-st:masterfrom
bardo84 wants to merge 1 commit intoSOM-st:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a Windows-compatible version of
som-rs.The current
masterbranch fails to build on Windows because of themmtkdependency, which does not support WindowThis is a known issue in
mmtk.This PR introduces a
windows-compatiblebranch that uses an older version of the code from beforemmtkwasintroduced. This version uses a different garbage collector that is compatible with Windows.
The code has been patched to compile on modern Rust, and the test suite passes.
This allows developers to build and run
som-rson Windows, which is currently not possible with themasterbranchThe trade-off is that this version uses an older, potentially less performant, garbage collector.