Merged
Conversation
70a3d22 to
d012548
Compare
…DOT/NINEDOT-CLIENT into feat/#89/mandal-all
빌드 결과빌드 성공 🎉 |
빌드 결과빌드 성공 🎉 |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
✅ Tasks
MandalartGrid.tsx- 3x3 그리드 로직을 별도 컴포넌트로 분리 -> 그리드 렌더링 로직 재사용 가능하도록 개선했습니다.backgroundColor: colors.black01추가했습니다.👀 To Reviewer
MandalartGrid.tsx추가했습니다.생각한 로직은
큰 3x3 그리드 (전체 보기)
각 칸 안에 또 3x3 그리드 (개별 만다라트)
이 구조에서 반복되는 부분, "3x3 그리드를 그리고 각 칸에 무언가를 넣는" 부분을 재사용 가능한 컴포넌트로 분리했습니다.
왜 만들었을까요:
리뷰 시 확인 부탁드릴 사항:
봐주시면 감사할 것 같습니다.
const CENTER_INDEX = 4;얜 따로 상수로 빼려고 했는데... 한 줄이라 굳이 분리하지 않았습니다. 참고해주세요.📸 Screenshot
2025-07-12.3.47.26.mov