Merged
Conversation
…NINEDOT/NINEDOT-CLIENT into feat/#52/goalUpperWrite
jisooooooooooo
requested review from
Leeyoonji23,
kwonsaebom and
shinjigu
as code owners
Closed
1 task
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
kwonsaebom
reviewed
Jul 14, 2025
Contributor
kwonsaebom
left a comment
kwonsaebom
left a comment
There was a problem hiding this comment.
수고많으셨습니다 !!
리뷰 몇 개만 확인해주세요 😽
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 실패 😵 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
kwonsaebom
approved these changes
Jul 15, 2025
shinjigu
approved these changes
Jul 15, 2025
Contributor
shinjigu
left a comment
shinjigu
left a comment
There was a problem hiding this comment.
전체적으로 컴포넌트 구조를 체계적으로 분리하고, 상태 관리를 props로 잘 해주셔서 하위 목표 뷰 구현에 참고 많이 했습니다 ㅎ.ㅎ
Comment on lines
+40
to
+50
| const handleAiSubmit = (selected: string[]) => { | ||
| const updated = [...subGoals]; | ||
| let selectedIndex = 0; | ||
| for (let i = 0; i < updated.length; i++) { | ||
| if (updated[i].trim() === '' && selectedIndex < selected.length) { | ||
| updated[i] = selected[selectedIndex]; | ||
| selectedIndex++; | ||
| } | ||
| } | ||
| setSubGoals(updated); | ||
| }; |
Contributor
There was a problem hiding this comment.
p5) AI 추천 모달 처리 로직이 잘 구현되어 있네용 빈 칸만 채우는 로직이 사용자 친화적입니다 🫶🏻
Comment on lines
+23
to
+29
| const updatedValues = (index: number, newValue: string) => | ||
| values.map((v, i) => (i === index ? newValue : v)); | ||
|
|
||
| const handleChange = (index: number, newValue: string) => { | ||
| const newValues = updatedValues(index, newValue); | ||
| onChange(newValues); | ||
| }; |
Contributor
There was a problem hiding this comment.
p5) updatedValues 함수 분리한 것 좋네용
Comment on lines
+33
to
+40
| {values.map((value, index) => ( | ||
| <TextField | ||
| key={index} | ||
| variant="subGoal" | ||
| value={value} | ||
| onChange={(val) => handleChange(index, val)} | ||
| placeholder={`${ORDER_LABELS[index]} ${DEFAULT_PLACEHOLDER.subGoal}`} | ||
| /> |
Contributor
There was a problem hiding this comment.
p4) key={index}를 사용하는 것보다 고유한 식별자를 사용하는 것이 좋지 않을까라는 생각이 들었지만 배열 순서가 변경되지 않는다면 현재 방식도 좋아요 !!
Collaborator
Author
There was a problem hiding this comment.
고정으로 8개 텍스트 필드를 사용하고 있어서 index를 사용하긴 했는데 어떻게 생각하시나요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
✅ Tasks
상위 목표 뷰 구현
👀 To Reviewer
📸 Screenshot