-
Notifications
You must be signed in to change notification settings - Fork 2
[Refactor]: 전체 목표 뷰 리팩토링 #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
f8c0188
refactor: 타이핑 훅 리팩토링
jisooooooooooo 14c7732
refactor: 전체 목표 작성 뷰 리팩토링
jisooooooooooo f09295c
refactor: 스타일 코드 리팩토링 및 토큰화
jisooooooooooo 2ab4862
refactor: 훅 구조 리팩토링
jisooooooooooo 2086d6b
chore: 네이밍 수정
jisooooooooooo 6bb0b0d
fix: lint 에러 해결
jisooooooooooo e2ffbab
refactor: 전체 목표 관련 네이밍 통일
jisooooooooooo 541bc70
fix: 빌드 에러 해결
jisooooooooooo a9a164c
fix: 네이밍 수정
jisooooooooooo 7b99828
fix: 코드리뷰 반영
jisooooooooooo 472216d
Merge branch 'develop' of https://github.com/SOPT-36-NINEDOT/NINEDOT-…
jisooooooooooo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { useMutation, type UseMutationOptions } from '@tanstack/react-query'; | ||
|
|
||
| import { | ||
| postEntireTodo, | ||
| type CreateEntireTodoRequest, | ||
| type CreateEntireTodoResponse, | ||
| } from '@/api/domain/entireTodo'; | ||
| import { QUERY_KEY } from '@/api/constant/queryKey'; | ||
|
|
||
| export const useCreateEntireTodo = ( | ||
| options?: UseMutationOptions<CreateEntireTodoResponse, unknown, CreateEntireTodoRequest>, | ||
| ) => { | ||
| return useMutation<CreateEntireTodoResponse, unknown, CreateEntireTodoRequest>({ | ||
| mutationKey: [...QUERY_KEY.ENTIRE_TODO, 'create'], | ||
| mutationFn: postEntireTodo, | ||
| ...options, | ||
| }); | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,20 @@ | ||
| import axiosInstance from '@/api/axiosInstance'; | ||
| import { END_POINT } from '@/api/constant/endPoint'; | ||
| import type { BaseResponse } from '@/type/api'; | ||
| import type { | ||
| CreateOverallTodoRequest, | ||
| CreateOverallTodoResponse, | ||
| } from '@/api/domain/entireTodo/type/entireTodo'; | ||
|
|
||
| export const postOverallTodo = async ( | ||
| body: CreateOverallTodoRequest, | ||
| ): Promise<BaseResponse<CreateOverallTodoResponse>> => { | ||
| const res = await axiosInstance.post<BaseResponse<CreateOverallTodoResponse>>( | ||
| END_POINT.MANDALART, | ||
| body, | ||
| ); | ||
| return res.data; | ||
| export interface CreateEntireTodoRequest { | ||
| title: string; | ||
| } | ||
|
|
||
| export interface CreateEntireTodoResponse { | ||
| id: number; | ||
| title: string; | ||
| } | ||
|
|
||
| export const postEntireTodo = async ( | ||
| body: CreateEntireTodoRequest, | ||
| ): Promise<CreateEntireTodoResponse> => { | ||
| const res = await axiosInstance.post<{ | ||
| data: CreateEntireTodoResponse; | ||
| }>(END_POINT.MANDALART, body); | ||
| return res.data.data; | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,26 @@ | ||
| import { style } from '@vanilla-extract/css'; | ||
|
|
||
| import { colors } from '@/style/token'; | ||
| import { fonts } from '@/style/token/typography.css'; | ||
| import { colors, fonts, layout } from '@/style/token'; | ||
|
|
||
| export const todoContainer = style({ | ||
| ...layout.columnCenter, | ||
| height: '100vh', | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| alignItems: 'center', | ||
| justifyContent: 'center', | ||
| backgroundColor: colors.bg_black01, | ||
| position: 'relative', | ||
| overflow: 'hidden', | ||
| }); | ||
|
|
||
| export const todoTitle = style({ | ||
| color: colors.white01, | ||
| ...fonts.display01, | ||
| color: colors.white01, | ||
| textAlign: 'center', | ||
| whiteSpace: 'pre-line', | ||
| marginBottom: '5.6rem', | ||
| position: 'relative', | ||
| zIndex: 1, | ||
| height: '15.2rem', | ||
| }); | ||
|
|
||
| export const todoInputContainer = style({ | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| alignItems: 'center', | ||
| ...layout.rowCenter, | ||
| gap: '2rem', | ||
| position: 'relative', | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p5) requestAnimationFrame 정확한 취소 관리와 duration <= 0 방어 로직 부분 언마운트/예외 케이스 안정성이 올라갔다는 점에서 좋다고 생각합니다 !