Merged
Conversation
jisooooooooooo
requested review from
Leeyoonji23 and
shinjigu
as code owners
Closed
2 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
kwonsaebom
approved these changes
Sep 12, 2025
Contributor
kwonsaebom
left a comment
kwonsaebom
left a comment
There was a problem hiding this comment.
깔끔한 리팩토링 ! 수고 많으셨습니다 !!
특히 useOverlayModal 부분은 단순하게 상태 관리만 한 게 아니라 스택까지 고려해서 설계하신 것 같아서 많이 배워갑니다 ... 🤩 👍🏻👍🏻
Leeyoonji23
reviewed
Sep 13, 2025
Contributor
Leeyoonji23
left a comment
Leeyoonji23
left a comment
There was a problem hiding this comment.
고생하셨습니다~! 코멘트 확인해주세욥!
빌드 결과빌드 실패 😵 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
shinjigu
approved these changes
Sep 14, 2025
Contributor
shinjigu
left a comment
shinjigu
left a comment
There was a problem hiding this comment.
흩어져 있던 모달 구현 방식을 공통 베이스 컴포넌트와 전역 관리 로직으로 정리해 주셔서 중복을 줄이고 사용성을 높인 점이 특히 좋다고 생각합니다 !! 코드가 단순해진 덕분에 새로운 모달을 추가하거나 수정할 때도 훨씬 일관성 있게 작업할 수 있을 것 같아요 수고하셨습니다 😻😻😻
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
✅ Tasks
AI 모달 리팩토링
AiRecommendModal,AiFailModal을 각각 따로 관리하던 구조에서 스타일이 중복되는 부분을 공통 베이스 컴포넌트로 분리했습니다.overlay-kit 적용
useModal훅으로 모달 열림/닫힘을 관리하던 로직에overlay-kit를 적용했습니다.OverlayProvider가 모달을 관리하도록 해서 페이지에서ModalWrapper를 직접 렌더하지 않아도 동작하게 개선했습니다.👀 To Reviewer