Merged
Conversation
빌드 결과빌드 실패 😵 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
shinjigu
approved these changes
Jul 9, 2025
Contributor
shinjigu
left a comment
shinjigu
left a comment
There was a problem hiding this comment.
원숭지숭언니 진짜 헤더와 푸터 구현 수고하셨습니다 !!
Comment on lines
+19
to
+20
| <p className={styles.infoText}>대표: 이현준</p> | ||
| <p className={styles.infoText}>이메일: 999inedot@gmail.com</p> |
Contributor
There was a problem hiding this comment.
p3) 사이트 제작자의 이름이나 제작자의 웹 페이지 또는 피드백을 위한 연락처 정보는 <address> 태그 활용해 보는 것도 좋을 것 같아요 !!
Comment on lines
+40
to
+41
| aria-current={activeMenu === menu.label ? 'page' : undefined} | ||
| > |
Contributor
There was a problem hiding this comment.
p5) aria-current 속성 사용 좋아요 🙊
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
kwonsaebom
approved these changes
Jul 9, 2025
Contributor
kwonsaebom
left a comment
kwonsaebom
left a comment
There was a problem hiding this comment.
수고많으셨습니다 !! 최고최고 👍🏻 👍🏻
| export const header = style({ | ||
| position: 'sticky', | ||
| top: 0, | ||
| zIndex: 100, |
Contributor
There was a problem hiding this comment.
p2) zIndex 는 따로 토큰 처리해놓아서 가져다 쓰시면 될 것 같습니다 !!
| }); | ||
|
|
||
| export const navItemActive = style({ | ||
| color: `${colors.grey11} !important`, |
Contributor
There was a problem hiding this comment.
p3) !important 사용보다는 다른 스타일 우선순위로 조정해보는 게 더 좋지 않을까 … 라는 생각을 해봤습니다 ㅎㅎ 나중에 유지보수할 때도 좀 더 안정적일 것 같아요 !
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
✅ Tasks
👀 To Reviewer
📸 Screenshot
2025-07-09.9.53.03.mov