Merged
Conversation
jisooooooooooo
requested review from
Leeyoonji23,
kwonsaebom and
shinjigu
as code owners
1 task
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
kwonsaebom
approved these changes
Jul 11, 2025
Contributor
kwonsaebom
left a comment
kwonsaebom
left a comment
There was a problem hiding this comment.
수고 많으셨습니다 !! 몇개 리뷰만 확인 부탁드려요 ~ ㅎㅎ
Comment on lines
+14
to
+16
| <button type="button" className={styles.iconWrapper}> | ||
| <IcModalDelete className={styles.closeIcon} onClick={onClose} /> | ||
| </button> |
Contributor
There was a problem hiding this comment.
p2) 방금 저희 팀 리드한테 배웠는데 아이콘에 바로 onClick 을 넣지 말고 button에 onClick을 넣으면 접근성 면에서 좋을 것 같아요 😛~!!
+) iconWrapper 스타일 속성을 marginLeft: 'auto'으로 바꾸면 될 것 같습니다 ㅎㅎ
Comment on lines
+22
to
+24
| display: 'flex', | ||
| justifyContent: 'flex-end', | ||
| alignItems: 'center', |
Contributor
There was a problem hiding this comment.
p3) 아래의 리뷰대로 onClick을 수정하면 여기 속성은 marginLeft: 'auto' 로 수정하면 될 것 같습니다 !
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
Leeyoonji23
approved these changes
Jul 11, 2025
| <p className={styles.description}>다시 한 번 시도해주세요.</p> | ||
| </div> | ||
| <div className={styles.buttonWrapper}> | ||
| <MandalButton text="다시 시도" /> |
Contributor
There was a problem hiding this comment.
p4) 읭 여기 핸들러가 없는 것 같은데 나중에 추가되는건가용?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
✅ Tasks
1. AI 추천 실패 모달 구현
2. MandalButton → Button 컴포넌트로 통합
👀 To Reviewer
📸 Screenshot