Merged
Conversation
kwonsaebom
requested review from
Leeyoonji23,
jisooooooooooo and
shinjigu
as code owners
2 tasks
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
jisooooooooooo
approved these changes
Jul 11, 2025
Collaborator
jisooooooooooo
left a comment
jisooooooooooo
left a comment
There was a problem hiding this comment.
굿이여 ~
수고하셨서여 🔥🔥🤭
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
빌드 결과빌드 성공 🎉 |
🎨 스토리북 배포 완료!변경된 컴포넌트의 디자인을 확인해주세요. |
shinjigu
approved these changes
Jul 11, 2025
Comment on lines
+4
to
+5
| const STREAK_BANNER_MESSAGE = '작은 실천을 66일 이어가면 나의 목표에 도달합니다'; | ||
| const STREAK_DESCRIPTION_MESSAGE = '하루에 하나라도 실천하면 오늘의 점이 찍혀요!'; |
Contributor
There was a problem hiding this comment.
p4) 별도의 constants 파일을 만드시는 건 어떻게 생각하시나요 ?
Contributor
Author
There was a problem hiding this comment.
아직은 상수가 이 두개밖에 안쓰여서 나중에 추가되면 파일로 분리해서 작성하도록 하겠습니다 !!
jisooooooooooo
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Summary
✅ Tasks
👀 To Reviewer
언제나 그렇듯 폴더 구조, 파일 구조, 파일 분리가 어렵네여 ..
📸 Screenshot