Conversation
# Conflicts: # app/build.gradle.kts # gradle/libs.versions.toml
znayeonzn
approved these changes
Nov 24, 2025
| data object Loading : UiState<Nothing> | ||
|
|
||
| data class Success<T>( | ||
| data class Success<out T>( |
Collaborator
Author
There was a problem hiding this comment.
Success에 out T를 붙이면 Success을 Success로도 볼 수 있어서
클래스 자체를 타입으로 사용할 때 상위 타입 호환성을 유지할 수 있습니다.
근데 생각해보니 Success만 따로 다룰 일이 없어서 굳이 out을 써주지 않아도 되겠네요..!
Comment on lines
+13
to
+14
| constructor() : ViewModel() { | ||
| private val _uiState = MutableStateFlow<OrderUiState>(OrderUiState()) |
Collaborator
There was a problem hiding this comment.
우와 생성자를 이렇게 쓰는 건 첨 보는 형식 같아요! 이렇게 쓰신 이유가 특별히 있으신가요?!
Collaborator
Author
There was a problem hiding this comment.
타입 명시해준 것 말씀하시는 건가욥..??!
특별한 이유가 있는 것은 아니고.. 그냥 습관적으로 써버렸는데.. 타입 추론 되는 부분이라 생략해줘도 될 것 같네요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
수정 요청이 온 경우 수정 후 다시 push를 합니다.
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
Screen_recording_20251121_191101.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
서버 연결하면 뷰모델이랑 Route 로직 좀 바뀔 것 같습니당