Conversation
1 task
jyvnee
reviewed
Nov 26, 2025
Comment on lines
+99
to
+104
| val sizePrice = when (selectedSize) { | ||
| DrinkSize.TALL -> menu.sizePrices.tall | ||
| DrinkSize.GRANDE -> menu.sizePrices.grande | ||
| DrinkSize.VENTI -> menu.sizePrices.venti | ||
| } | ||
| val totalPrice = menu.price + sizePrice |
Collaborator
There was a problem hiding this comment.
이 로직은 뷰모델로 안 빼고 UI에서 처리하는 이유가 있나요??
Collaborator
Author
There was a problem hiding this comment.
UI 상태에 따라 단순 계산을 해서 UI에서 처리했습니다!
Comment on lines
+69
to
+85
| modifier = modifier | ||
| .fillMaxSize() | ||
| .background(StarbucksTheme.colors.white) | ||
| ) { | ||
| uiState.menuLoadState.onSuccess { menu -> | ||
| MyMenuContent( | ||
| menu = menu, | ||
| selectedTab = uiState.selectedTab, | ||
| selectedSize = uiState.selectedSize, | ||
| isPersonalCupChecked = uiState.isPersonalCupChecked, | ||
| onTabSelected = onTabSelected, | ||
| onSizeSelected = onSizeSelected, | ||
| onPersonalCupToggle = onPersonalCupToggle, | ||
| onBackClick = onBackClick | ||
| ) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
혹시 여기서 밖에 Column으로 감싸신 이유가 있나요?? MyMenuContent 안에서도 Column 써서 Column이 특별한 이유 없이 중첩되는 것 같은데 Column을 사용하신 이유가 궁금합니다
Collaborator
Author
There was a problem hiding this comment.
아 처음에는 Loading, Error에 대해서 처리하는 부분을 넣으려고 해서 한번 감쌌는데,, 일단 성공 로직만 화면에 보이게 해서 바깥의 Coulmn을 제거하겠습니다!
jyvnee
reviewed
Nov 26, 2025
| Column( | ||
| modifier = Modifier | ||
| .weight(1f) | ||
| .verticalScroll(rememberScrollState()) |
Collaborator
There was a problem hiding this comment.
보니까 PersonalOptionContent랑 MyMenuRegisterBar 사이에 패딩 있어서 Column에 bottom 패딩 주던가 PersonalOptionContent 아래에 따로 패딩 줘야 할 것 같아요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ 𝗖𝗵𝗲𝗰𝗸-𝗟𝗶𝘀𝘁
수정 요청이 온 경우 수정 후 다시 push를 합니다.
📌 𝗜𝘀𝘀𝘂𝗲𝘀
📎 𝗪𝗼𝗿𝗸 𝗗𝗲𝘀𝗰𝗿𝗶𝗽𝘁𝗶𝗼𝗻
📷 𝗦𝗰𝗿𝗲𝗲𝗻𝘀𝗵𝗼𝘁
2025-11-26.055953.mp4
💬 𝗧𝗼 𝗥𝗲𝘃𝗶𝗲𝘄𝗲𝗿𝘀
옵션 퍼스널 가격 부분을 제외하고 API 연결 및 가격 변경 로직을 추가해뒀습니다!