Merged
Conversation
sminha
requested review from
hamxxn,
huniversal and
woodzverse
as code owners
빌드 및 린트 결과모든 검사 통과 🎉
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Related Issues
✅ 체크 리스트
📄 Tasks
로딩 스피너 깜빡거림을 개선했어요.
⭐ PR Point (To Reviewer)
placeholderData: keepPreviousData로도 해결 가능하고,onMouseEnter이벤트 핸들러로prefetchShowtimes를 연결해줬어요.칩 위에 마우스가 hover되면 사용자가 해당 칩을 선택할 것으로 예상하고 데이터를 미리 캐시해둬요.
📷 Screenshot
자꾸 로딩 스피너가 0.1초 떴다가 사라져요.
로딩 스피너가 뜨지 않고 바로 상영 정보를 렌더링하고,
tanstack devtools를 보면 칩 위에 마우스가 hover되기만 해도 데이터가 캐시되는 것을 확인할 수 있어요!
🔔 ETC