Updates on USE_OTHER_TIME_FUNCTION

[homnath]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 25.80645% with 69 lines in your changes missing coverage. Please review.

Project coverage is 38.71%. Comparing base (a5bb135) to head (3e7a2b9).

Files with missing lines	Patch %	Lines
src/specfem3D/locate_source.F90	8.57%	32 Missing ⚠️
src/specfem3D/setup_sources_receivers.f90	30.00%	14 Missing ⚠️
src/specfem3D/compute_add_sources_viscoelastic.F90	7.14%	13 Missing ⚠️
src/specfem3D/get_cmt.f90	37.50%	5 Missing ⚠️
src/shared/read_parameter_file.F90	50.00%	3 Missing ⚠️
...roblem_for_model/input_output/input_output_mod.f90	87.50%	1 Missing ⚠️
src/shared/count_number_of_sources.f90	50.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a5bb135) and HEAD (3e7a2b9). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (a5bb135)	HEAD (3e7a2b9)
	5	4

Additional details and impacted files

@@             Coverage Diff             @@
##            devel    #1746       +/-   ##
===========================================
- Coverage   50.49%   38.71%   -11.79%     
===========================================
  Files         271      271               
  Lines       61738    61828       +90     
===========================================
- Hits        31177    23935     -7242     
- Misses      30561    37893     +7332     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[homnath]

Interestingly, "Test_run_example 4 - small adjoint" runs fine on my side!

[casarotti]

Is there any update on this topic? I was considering include the Yoffe STF in the loop

[danielpeter]

the patch above didn't make it into the devel version yet.

for force point sources (FORCESOLUTION), the Brune & smoothed Brune functions are implemented by using the setting source time function: 5 (or 6) in the FORCESOLUTION file. the above PR would have added a Par_file flag to achieve the same for CMTSOLUTION sources. a new pull request would need to be submitted for that.

[homnath]

Let me take another look at this 🙂 Best, Hom Nath

…

--------------------------------------- Hom Nath Gharti, PhD Assistant Professor | Digital Earth Scientist https://www.digitalearthscience.com/ Department of Geological Sciences and Geological Engineering Miller Hall 314, 36 Union St Queen’s University Kingston, ON K7L 3N6, Canada Queen’s University is situated on traditional Anishinaabe and Haudenosaunee Territory.<https://www.queensu.ca/encyclopedia/t/traditional-territories>

________________________________ From: daniel peter ***@***.***> Sent: Thursday, January 16, 2025 1:48 PM To: SPECFEM/specfem3d ***@***.***> Cc: Hom Nath Gharti ***@***.***>; State change ***@***.***> Subject: Re: [SPECFEM/specfem3d] Updates on USE_OTHER_TIME_FUNCTION (PR #1746) the patch above didn't make it into the devel version yet. for force point sources (FORCESOLUTION), the Brune & smoothed Brune functions are implemented by using the setting source time function: 5 (or 6) in the FORCESOLUTION file. the above PR would have added a Par_file flag to achieve the same for CMTSOLUTION sources. a new pull request would need to be submitted for that. — Reply to this email directly, view it on GitHub<#1746 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMCQ4RYBZ5RMQW3QVN7NV32K75IFAVCNFSM6AAAAABPQRXGMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJWGQ4DANBZGQ>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[adunham1]

@homnath Just wanted to chime in here, we worked together on this implementation about a year ago and I am currently using a working version for the smooth brune STF with a CMTSOLUTION for my simulations, I believe from your specfem3d fork. It would be great to see this new parameter in the devel version, I'm happy to help/run tests, just let me know!

[homnath]

Thanks, Audrey! Stay tuned. Best, Hom Nath

…

--------------------------------------- Hom Nath Gharti, PhD Assistant Professor | Digital Earth Scientist https://www.digitalearthscience.com/ Department of Geological Sciences and Geological Engineering Miller Hall 314, 36 Union St Queen’s University Kingston, ON K7L 3N6, Canada Queen’s University is situated on traditional Anishinaabe and Haudenosaunee Territory.<https://www.queensu.ca/encyclopedia/t/traditional-territories>

________________________________ From: Audrey Dunham ***@***.***> Sent: Thursday, January 23, 2025 3:12 PM To: SPECFEM/specfem3d ***@***.***> Cc: Hom Nath Gharti ***@***.***>; Mention ***@***.***> Subject: Re: [SPECFEM/specfem3d] Updates on USE_OTHER_TIME_FUNCTION (PR #1746) @homnath<https://github.com/homnath> Just wanted to chime in here, we worked together on this implementation about a year ago and I am currently using a working version for the smooth brune STF with a CMTSOLUTION for my simulations, I believe from your specfem3d fork. It would be great to see this new parameter in the devel version, I'm happy to help/run tests, just let me know! — Reply to this email directly, view it on GitHub<#1746 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABMCQ4S5P42FYWU7V2AHEIL2MFEKXAVCNFSM6AAAAABPQRXGMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJQHEZDGOJYHE>. You are receiving this because you were mentioned.Message ID: ***@***.***>