Skip to content

fix(sync): restore AppOwner mnemonic non-null parity#48

Merged
miccy merged 2 commits intomainfrom
sync/common-v8-2026-02-23-wave4
Feb 23, 2026
Merged

fix(sync): restore AppOwner mnemonic non-null parity#48
miccy merged 2 commits intomainfrom
sync/common-v8-2026-02-23-wave4

Conversation

@miccy
Copy link
Copy Markdown
Contributor

@miccy miccy commented Feb 23, 2026

Summary

  • restore upstream parity for AppOwner typing in packages/common/src/local-first/Owner.ts
  • fix regression introduced after common-v8 merge where mnemonic became nullable
  • align with upstream/common-v8 commit e6b0a6e intent (unnull mnemonic)

Change

  • readonly mnemonic?: Mnemonic | null; -> readonly mnemonic: Mnemonic;

Verification

  • bun clean
  • bun install
  • bun verify

All commands passed (only existing non-blocking Biome warnings in test files).

Summary by CodeRabbit

Poznámky k vydání

  • Refaktorování
    • Mnemonika u vlastníka aplikace je nyní povinná, což zlepšuje typovou bezpečnost a konzistenci inicializace objektů.
  • Testy
    • Přidán test ověřující, že převod mnemoniky tam a zpět zachovává původní tajný klíč.

@miccy miccy requested a review from a team as a code owner February 23, 2026 16:22
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 23, 2026

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 1cbdabf and 0bc20a5.

📒 Files selected for processing (2)
  • packages/common/src/local-first/Owner.ts
  • packages/common/test/local-first/Owner.test.ts

📝 Walkthrough

Walkthrough

Vlastnost mnemonic v rozhraní AppOwner byla změněna z volitelné na povinnou (readonly mnemonic?: Mnemonic | null;readonly mnemonic: Mnemonic;). Přidán test ověřující, že vytvořený AppOwner round-tripuje zpět původní tajemství.

Changes

Cohort / File(s) Summary
AppOwner typ a test
packages/common/src/local-first/Owner.ts, packages/common/test/local-first/Owner.test.ts
Změna signatury AppOwner.mnemonic z Mnemonic | null (volitelné) na povinné Mnemonic. Přidán test: createAppOwner ověřuje, že mnemonicToOwnerSecret(appOwner.mnemonic) se rovná zdrojovému tajemství.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 Mnemonic v tlapce držím pevně,

žádné nully teď, jen jasné věci,
AppOwner skáče, kód je čistý,
test mu tleská — všechno funguje hezky!


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@miccy miccy merged commit f6000cb into main Feb 23, 2026
7 checks passed
@miccy miccy deleted the sync/common-v8-2026-02-23-wave4 branch February 24, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant